TD-5186 Investigate the build failure for the dependabot Pull Request

DigitalLearningSolutions.Web.Tests/Controllers/Login/LoginControllerTests.cs

@@ -138,7 +138,7 @@ public async Task Invalid_model_should_render_basic_form_with_error()
 
             // Then
             result.Should().BeViewResult().WithViewName("Index").ModelAs<LoginViewModel>();
-            Assert.IsFalse(controller.ModelState.IsValid);
+            Assert.That(controller.ModelState.IsValid, Is.False);
         }
 
         [Test]
@@ -263,7 +263,7 @@ public async Task Invalid_credentials_should_render_basic_form_with_error()
 
             // Then
             result.Should().BeViewResult().WithViewName("Index").ModelAs<LoginViewModel>();
-            Assert.IsFalse(controller.ModelState.IsValid);
+            Assert.That(controller.ModelState.IsValid, Is.False);
         }
 
         [Test]
@@ -279,7 +279,7 @@ public async Task Login_to_unclaimed_delegate_account_should_render_basic_form_w
 
             // Then
             result.Should().BeViewResult().WithViewName("Index").ModelAs<LoginViewModel>();
-            Assert.IsFalse(controller.ModelState.IsValid);
+            Assert.That(controller.ModelState.IsValid, Is.False);
         }
 
         [Test]

DigitalLearningSolutions.Web.Tests/Controllers/Register/ClaimAccountControllerTests.cs

@@ -515,7 +515,7 @@ public async Task CompleteRegistrationPost_with_invalid_model_display_with_valid
                 .ModelAs<ClaimAccountCompleteRegistrationViewModel>().Should()
                 .BeEquivalentTo(completeRegistrationViewModel);
 
-            Assert.IsFalse(controller.ModelState.IsValid);
+            Assert.That(controller.ModelState.IsValid, Is.False);
         }
 
         [Test]

DigitalLearningSolutions.Web.Tests/Controllers/SupervisorController/SupervisorControllerTests.cs

@@ -150,8 +150,8 @@ public void ExportCandidateAssessment_should_return_file_object_with_file_name_i
             // Assert
             Assert.Multiple(() =>
             {
-                Assert.IsNotNull(result);
-                Assert.AreEqual(expectedFileName, result!.FileDownloadName);
+                Assert.That(result, Is.Not.Null);
+                Assert.That(result!.FileDownloadName, Is.EqualTo(expectedFileName));
             });
         }
 

DigitalLearningSolutions.Web.Tests/Controllers/TrackingSystem/Centre/Configuration/CentreConfigurationControllerTests.cs

@@ -87,7 +87,7 @@ public void EditCentreWebsiteDetails_should_show_validation_error_to_user_when_g
             // Then
             result.Should().BeViewResult().WithDefaultViewName()
                 .ModelAs<EditCentreWebsiteDetailsViewModel>();
-            Assert.IsFalse(controller.ModelState.IsValid);
+            Assert.That(controller.ModelState.IsValid, Is.False);
         }
 
         [TestCase("OVER_DAILY_LIMIT")]

DigitalLearningSolutions.Web.Tests/Controllers/TrackingSystem/Delegates/DeactivateDelegateControllerTests.cs

@@ -96,7 +96,7 @@ public void Index_post_returns_error_when_no_option_selected_to_deactivate()
 
             // Then
             result.Should().BeViewResult().ModelAs<DeactivateDelegateAccountViewModel>().DelegateId.Should().Be(DelegateId);
-            Assert.IsFalse(controller.ModelState.IsValid);
+            Assert.That(controller.ModelState.IsValid, Is.False);
         }
 
 

DigitalLearningSolutions.Web.Tests/Controllers/TrackingSystem/Delegates/EnrolControllerTests.cs

@@ -72,7 +72,7 @@ public void StartEnrolProcess_calls_expected_methods_and_returns_view()
 
                 result.Should().BeRedirectToActionResult().WithActionName("Index");
 
-                Assert.AreEqual(0, tempDataDictionary.Keys.Count);
+                Assert.That(tempDataDictionary.Keys.Count, Is.EqualTo(0));
             }
         }
     }

DigitalLearningSolutions.Web.Tests/DigitalLearningSolutions.Web.Tests.csproj

@@ -12,7 +12,7 @@
     <PackageReference Include="FluentAssertions" Version="5.10.3" />
     <PackageReference Include="FluentAssertions.AspNetCore.Mvc" Version="3.2.0" />
     <PackageReference Include="NBuilder" Version="6.1.0" />
-    <PackageReference Include="NUnit" Version="3.14.0" />
+    <PackageReference Include="NUnit" Version="4.3.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
   </ItemGroup>

DigitalLearningSolutions.Web.Tests/Services/CryptoServiceTests.cs

@@ -20,7 +20,7 @@ public void VerifyHashedPassword_Returns_false_if_hashed_password_is_empty()
             var passwordIsCorrect = cryptoService.VerifyHashedPassword(null, "password");
 
             // Then
-            Assert.IsFalse(passwordIsCorrect);
+            Assert.That(passwordIsCorrect, Is.False);
         }
 
         [Test]
@@ -32,7 +32,7 @@ public void VerifyHashedPassword_Returns_true_for_hash_from_GetPasswordHash()
             var passwordIsCorrect = cryptoService.VerifyHashedPassword(passwordHash, password);
 
             // Then
-            Assert.IsTrue(passwordIsCorrect);
+            Assert.That(passwordIsCorrect, Is.True);
         }
     }
 }

DigitalLearningSolutions.Web.Tests/Services/FreshdeskServiceTests.cs

@@ -40,7 +40,7 @@ public void CreateNewTicket_returns_ticket_id_API_success()
             var apiResponse = freshdeskService.CreateNewTicket(ticketRequest);
 
             //Assert 
-            Assert.AreEqual(expectedResponse, apiResponse);
+            Assert.That(apiResponse, Is.EqualTo(expectedResponse));
         }
         [Test]
         public void CreateNewTicket_returns_API_Authentication_error()
@@ -60,7 +60,7 @@ public void CreateNewTicket_returns_API_Authentication_error()
             var apiResponse = freshdeskService.CreateNewTicket(ticketRequest);
 
             //Assert 
-            Assert.AreEqual(expectedResponse, apiResponse);
+            Assert.That(apiResponse, Is.EqualTo(expectedResponse));
         }
         [Test]
         public void CreateNewTicket_returns_API_error()
@@ -80,7 +80,7 @@ public void CreateNewTicket_returns_API_error()
             var apiResponse = freshdeskService.CreateNewTicket(ticketRequest);
 
             //Assert 
-            Assert.AreEqual(expectedResponse, apiResponse);
+            Assert.That(apiResponse, Is.EqualTo(expectedResponse));
         }
         [Test]
         public async Task CreateNewTicket_returns_API_data_if_retrieved()
@@ -100,7 +100,7 @@ public async Task CreateNewTicket_returns_API_data_if_retrieved()
             var apiResponse = freshdeskService.CreateNewTicket(ticketRequest);
 
             //Assert 
-            Assert.AreEqual(expectedResponse, apiResponse);
+            Assert.That(apiResponse, Is.EqualTo(expectedResponse));
         }
     }
 }