Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Jan 22, 2025

JIRA link

TD-5138

Description

Made a change to the count query on the dashboard, and used the query that provides the details once the staff number is clicked on the dashboard, used the count function to show the number of staffs.

Screenshots

No screenshots as such since the UI code was not tampered.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

kevwhitt-hee and others added 22 commits January 10, 2025 09:49
…ures/TD-5233-BulkImportTidyUp

TD-5233 bulk import tidy up tasks
…ures/TD-5263-ExportForPreview

TD-5263 Frameworks View for print feature
@ABSinhaa ABSinhaa marked this pull request as ready for review January 22, 2025 12:34
@ABSinhaa ABSinhaa changed the base branch from DLS-Release-v1.2.0 to DLS-Release-v1.1.1 January 23, 2025 14:59
@ABSinhaa ABSinhaa changed the base branch from DLS-Release-v1.1.1 to DLS-Release-v1.2.0 January 23, 2025 15:09
@ABSinhaa ABSinhaa closed this Jan 23, 2025
@ABSinhaa ABSinhaa deleted the Develop/fixes/TD-5138_Staff_Account_Incorrect branch January 23, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants