TD-5220 fix order comparison for ungrouped competencies #3227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
TD-5220
Description
Because ungrouped competency ordering is broken (order is 1 for all competencies) the preprocess is still reporting a competency order change for frameworks with ungrouped competencies that haven't been reordered. Adding FC.ID to the ORDER BY clause for the download and preprocess get competency order queries ensures like a like-for-like comparison to avoid this problem.
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: