Skip to content

TD-5542 Issue not focussing to the respective fields when clicked the error links on the frameworks section #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

TD-5542 Issue not focussing to the respective fields when clicked the error links on the frameworks section #3243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DigitalLearningSolutions.Web/Controllers/FrameworksController/Competencies.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ public IActionResult AddEditFrameworkCompetency(int frameworkId, FrameworkCompet
FrameworkCompetency = frameworkCompetency,
CompetencyFlags = competencyFlags
};
ModelState.Remove("SearchableName");
return View("Developer/Competency", model);
}
var adminId = GetAdminId();
Expand Down
2 changes: 1 addition & 1 deletion DigitalLearningSolutions.Web/Views/Frameworks/Developer/Competency.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
@Model.VocabSingular() statement
</label>
<span nhs-validation-for="FrameworkCompetency.Name"></span>
<input class="nhsuk-input" asp-for="FrameworkCompetency.Name" id="competency-name" name="Name" type="text" error-class-toggle="nhsuk-input--error" aria-describedby="competency-name-label">
<input class="nhsuk-input" asp-for="FrameworkCompetency.Name" id="Name" name="Name" type="text" error-class-toggle="nhsuk-input--error" aria-describedby="competency-name-label">
</nhs-form-group>
<div class="nhsuk-form-group">
<vc:text-area asp-for="FrameworkCompetency.Description"
Expand Down
4 changes: 2 additions & 2 deletions DigitalLearningSolutions.Web/Views/Frameworks/Developer/CompetencyGroup.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@
<partial name="_ErrorSummary" />
}
<nhs-form-group nhs-validation-for="CompetencyGroupBase.Name">
<label class="nhsuk-label" id="competency-group-name-label" for="competency-group-name">
<label class="nhsuk-label" id="competency-group-name-label" for="Name">
@Model.VocabSingular() group name
</label>
<span nhs-validation-for="CompetencyGroupBase.Name"></span>
<input class="nhsuk-input" asp-for="CompetencyGroupBase.Name" id="competency-group-name" name="Name" type="text" error-class-toggle="nhsuk-input--error" aria-describedby="competency-group-name-label">
<input class="nhsuk-input" asp-for="CompetencyGroupBase.Name" id="Name" name="Name" type="text" error-class-toggle="nhsuk-input--error" aria-describedby="competency-group-name-label">
</nhs-form-group>
<nhs-form-group nhs-validation-for="CompetencyGroupBase.Description">
<span nhs-validation-for="CompetencyGroupBase.Description"></span>
Expand Down
Loading