Skip to content

Conversation

@frank-hee
Copy link
Contributor

@frank-hee frank-hee commented Jun 3, 2025

JIRA link

TD-4916

Description

.nshuk classes removed from styles/index.scss and styles/layout.scss, added to /styles/nhsuk.scss

updates made to two _Layout.cshtml files to bring headers up to date. Some .nhsuk overrides were no longer necessary if using current classes and layouts.

Screenshots

image

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

rshrirohit and others added 30 commits March 11, 2025 21:55
…ure/TD-3711-AddingLastAccessedColumnsToTables

TD-3711 Adding Last Accessed Columns To Tables
…ure/TD-3712-UpdateLastAccessedDateForUsersDuringLogin

TD-3712 Update LastAccessed Date For Users During Login
…ure/TD-3713-UpdateLastAccessedDateForAdminAccountsAndDelegateAccounts

TD-3713- Update LastAccessed Date For AdminAccounts And DelegateAccounts
…ure/TD-3714-AddingLastAccessedDateToDelegatesCardInTrackingSystem

TD-3714 Adding LastAccessed Date To Delegates Card In Tracking System
…ure/TD-3716-AddingLastAccessedDateInAdminCard

TD-3716 Adding LastAccessed Date In Admin Card
…s/TD-3717-AddingLastAccessedDateInSuperAdminUserAccountsCard

TD-3717 Adding LastAccessed Date In SuperAdmin UserAccounts Card
…ure/TD-3715-IncludingLastAccessedDateInDelegatesExport

TD-3715 Including last accessed date in delegates export
…ture/TD-3718-AddingLastAccessedDateinSuperAdminAdministratorsCard

TD-3718 Adding LastAccessed Date in SuperAdmin Administrators Card
…s/TD-3719-IncludingLastAccessedDateInSuperAdminDelegatesCard

TD-3719 Including LastAccessed Date In SuperAdmin Delegates Card
…TD-5443-Issue-allowing-to-add-multiple-flags

TD-5443-Added check for existing flag names prior to add or edit custom flags.
…ure/TD-5435-Move-Todo-list-above-Staff

TD-5435-'To Do' section has been moved above the 'Staff' section.
rshrirohit and others added 24 commits March 25, 2025 14:17
…ure/TD-5436-Todo-list-above-Frameworks

TD-5436-'To Do' list has been moved above the 'Frameworks' section.
…TD-5438-Move-View-Proficiencies-to-the-top

TD-5438-Moved the 'View Proficiencies' button to the top.
…ure/TD-5439-Include-description-details-bulk-confirmation

TD-5439 - A competency description is added to competency when it exists.
…ure/TD-5482-Role-on-My-Staff-page

TD-5482-Related supervisor role added to view.
…ure/TD-5481-complete-list-of-supervisors-Activity-delegates

TD-5481-Added a Details view component to show supervisor list.
…TD-5511-View-Edit-link-for-frameworks

TD-5511- The admin userid is used to check the framework owner
…TD-5514-Course-completion-overdue-emails

TD-5514-Stored proc updated to add course name in the email subject
…TD-5451-SelfAssessment-expander-issue

TD-5451- Empty competency description check added
@frank-hee frank-hee self-assigned this Jun 3, 2025
@frank-hee frank-hee added the enhancement New feature or request label Jun 3, 2025
@frank-hee frank-hee closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants