-
Notifications
You must be signed in to change notification settings - Fork 1
Develop/fixes/td 4916 nhsuk override consolidation #3286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
frank-hee
wants to merge
54
commits into
master
from
Develop/Fixes/TD-4916-nhsuk-override-consolidation
Closed
Develop/fixes/td 4916 nhsuk override consolidation #3286
frank-hee
wants to merge
54
commits into
master
from
Develop/Fixes/TD-4916-nhsuk-override-consolidation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/TD-3711-AddingLastAccessedColumnsToTables TD-3711 Adding Last Accessed Columns To Tables
…ure/TD-3712-UpdateLastAccessedDateForUsersDuringLogin TD-3712 Update LastAccessed Date For Users During Login
…ure/TD-3713-UpdateLastAccessedDateForAdminAccountsAndDelegateAccounts TD-3713- Update LastAccessed Date For AdminAccounts And DelegateAccounts
…ure/TD-3714-AddingLastAccessedDateToDelegatesCardInTrackingSystem TD-3714 Adding LastAccessed Date To Delegates Card In Tracking System
…ure/TD-3716-AddingLastAccessedDateInAdminCard TD-3716 Adding LastAccessed Date In Admin Card
…s/TD-3717-AddingLastAccessedDateInSuperAdminUserAccountsCard TD-3717 Adding LastAccessed Date In SuperAdmin UserAccounts Card
…ure/TD-3715-IncludingLastAccessedDateInDelegatesExport TD-3715 Including last accessed date in delegates export
…ture/TD-3718-AddingLastAccessedDateinSuperAdminAdministratorsCard TD-3718 Adding LastAccessed Date in SuperAdmin Administrators Card
…s/TD-3719-IncludingLastAccessedDateInSuperAdminDelegatesCard TD-3719 Including LastAccessed Date In SuperAdmin Delegates Card
…TD-5443-Issue-allowing-to-add-multiple-flags TD-5443-Added check for existing flag names prior to add or edit custom flags.
…ure/TD-5435-Move-Todo-list-above-Staff TD-5435-'To Do' section has been moved above the 'Staff' section.
…ure/TD-5436-Todo-list-above-Frameworks TD-5436-'To Do' list has been moved above the 'Frameworks' section.
…TD-5438-Move-View-Proficiencies-to-the-top TD-5438-Moved the 'View Proficiencies' button to the top.
…ure/TD-5439-Include-description-details-bulk-confirmation TD-5439 - A competency description is added to competency when it exists.
…ure/TD-5482-Role-on-My-Staff-page TD-5482-Related supervisor role added to view.
…ure/TD-5481-complete-list-of-supervisors-Activity-delegates TD-5481-Added a Details view component to show supervisor list.
…he framework owner
…TD-5511-View-Edit-link-for-frameworks TD-5511- The admin userid is used to check the framework owner
…TD-5514-Course-completion-overdue-emails TD-5514-Stored proc updated to add course name in the email subject
…TD-5451-SelfAssessment-expander-issue TD-5451- Empty competency description check added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
TD-4916
Description
.nshuk classes removed from styles/index.scss and styles/layout.scss, added to /styles/nhsuk.scss
updates made to two _Layout.cshtml files to bring headers up to date. Some .nhsuk overrides were no longer necessary if using current classes and layouts.
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: