- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
TD-4916 nhsuk override consolidation #3287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD-4916 nhsuk override consolidation #3287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few changes included in this PR that shouldn't be there, I believe. Please could this be addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be deleted.
| @frank-hee give me a nudge when the above has been addressed, and I'll pull your branch and test. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Built branch, worked through application screens in mobile and desktop and saw no styling issues.
JIRA link
TD-4916
Description
.nhsuk items moved from index.scss and layout.scss into nhsuk.scss
_layout.cshtml headers updated to reflect current design system and remove need for several overrides
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: