Skip to content

Conversation

@frank-hee
Copy link
Contributor

@frank-hee frank-hee commented Jun 4, 2025

JIRA link

TD-4916

Description

.nhsuk items moved from index.scss and layout.scss into nhsuk.scss
_layout.cshtml headers updated to reflect current design system and remove need for several overrides

Screenshots

image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@frank-hee frank-hee self-assigned this Jun 4, 2025
@rshrirohit rshrirohit changed the title Develop/fixes/td 4916 nhsuk override consolidation TD-4916 nhsuk override consolidation Jun 5, 2025
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few changes included in this PR that shouldn't be there, I believe. Please could this be addressed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be deleted.

@kevwhitt-hee
Copy link
Contributor

@frank-hee give me a nudge when the above has been addressed, and I'll pull your branch and test.

@rshrirohit rshrirohit changed the base branch from DLS-Release-v1.2.1 to DLS-Release-v1.2.2 June 19, 2025 10:19
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Built branch, worked through application screens in mobile and desktop and saw no styling issues.

@frank-hee frank-hee merged commit 6bdddeb into DLS-Release-v1.2.2 Jun 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants