Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Jun 11, 2025

JIRA link

TD-5547

Description

Added centre custom Prompt changes to the DSAT report generation code.

Screenshots

Backend changes


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@ABSinhaa ABSinhaa requested a review from rshrirohit June 11, 2025 22:16
@ABSinhaa ABSinhaa changed the title TD-5547_Test failed for DSAT code changes. TD-5547_Test failed for DSAT custom centre prompts code changes. Jun 11, 2025
@ABSinhaa ABSinhaa marked this pull request as ready for review June 11, 2025 22:39
@rshrirohit rshrirohit merged commit 32c2bf6 into DLS-Release-v1.2.1 Jun 12, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-5547_Test_Fail_DSAT_Custom_Centre_Reports branch June 12, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants