Skip to content

Conversation

@rshrirohit
Copy link
Collaborator

JIRA link

DLS Wellington Release 1.2.1

Description

Merging to production for deployment

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

rshrirohit and others added 30 commits March 11, 2025 21:55
…ure/TD-3711-AddingLastAccessedColumnsToTables

TD-3711 Adding Last Accessed Columns To Tables
…ure/TD-3712-UpdateLastAccessedDateForUsersDuringLogin

TD-3712 Update LastAccessed Date For Users During Login
…ure/TD-3713-UpdateLastAccessedDateForAdminAccountsAndDelegateAccounts

TD-3713- Update LastAccessed Date For AdminAccounts And DelegateAccounts
…ure/TD-3714-AddingLastAccessedDateToDelegatesCardInTrackingSystem

TD-3714 Adding LastAccessed Date To Delegates Card In Tracking System
…ure/TD-3716-AddingLastAccessedDateInAdminCard

TD-3716 Adding LastAccessed Date In Admin Card
…s/TD-3717-AddingLastAccessedDateInSuperAdminUserAccountsCard

TD-3717 Adding LastAccessed Date In SuperAdmin UserAccounts Card
…ure/TD-3715-IncludingLastAccessedDateInDelegatesExport

TD-3715 Including last accessed date in delegates export
…ture/TD-3718-AddingLastAccessedDateinSuperAdminAdministratorsCard

TD-3718 Adding LastAccessed Date in SuperAdmin Administrators Card
…s/TD-3719-IncludingLastAccessedDateInSuperAdminDelegatesCard

TD-3719 Including LastAccessed Date In SuperAdmin Delegates Card
…TD-5443-Issue-allowing-to-add-multiple-flags

TD-5443-Added check for existing flag names prior to add or edit custom flags.
…ure/TD-5435-Move-Todo-list-above-Staff

TD-5435-'To Do' section has been moved above the 'Staff' section.
rshrirohit and others added 26 commits May 21, 2025 11:17
…s/TD-5547_Hard_Coded_Fields_Should_Be_Dynamic

TD-5547_Added logic to generate the Centre Custom Fields dynamically for Self Assessment Reports for a given centre.
…TD-5511-View-Edit-link-for-frameworks

TD-5511-SQL query modified to get correct admin user role of framework
…ure/TD-3718_Display_LastAccessed_SuperAdmin_Card

TD_3718 Adding the text 'Last accessed date' to the administrators card in the superadmin section
…ure/TD-3719_Display_LastAccessed_SuperAdmin_DelegateCard

TD_3719 Added 'Last accessed date' to the delegates card within the superadmin module
…ure/TD-5583_Display_LastAccessed_TrackingSystem_DeegatesCard

TD_5583_ Added Last accessed date field to the view delegates section within Tracking System
…s/TD-3715_Test_Failed_Change_LastAccessed_Lastaccesseddate_Delegate_Reports

TD-3715 Fix for initial test fail scenario changed Last Accessed column name to Last accessed date in delegate excel reports
…TD-5620-Competency-Empty-Description-Save-issue

TD-5620-Added code to check if the html editor is empty.
…s/TD-5581-Issueshowingmultiplecommentson'Frameworks'-'Comments'sectionwhenclickedbrowserbacklink

TD-5581 Issue showing multiple comments on 'Frameworks' - 'Comments' section when clicked browser back link
…TD-5443-Bulk-upload-Duplicate-flags

TD-5443-Bulk upload - Duplicate flags - existing flag comparison modified.
…s/TD-5581-Issueshowing'someexistingcompetencyrecordschangedorder'on'competencyfileuploaded'screenwhenmodifiedthecompetencies

Issue showing multiple comments on 'Frameworks' - 'Comments' section when clicked browser back link
…s/TD-3712-UpdatingLastAccessedForUnverifiedUsersLogin

TD-3712 Updating Last Accessed For Unverified Users Login
…TD-5511-View-Edit-link-for-frameworks

TD-5511-Sql modified to show FrameworkReviewID for admin logged in from different centre.
…delegates screen as the last accessed field was missing in the original view generation query.
…s/TD-5547_Test_Fail_DSAT_Custom_Centre_Reports

TD-5547_Test failed for DSAT custom centre prompts code changes.
…s/TD-5583_Test_Fail_Delegates_Screen_Data

TD_5583 Test failed for view delegates screen not showing the last accessed date data
@kevwhitt-hee kevwhitt-hee marked this pull request as ready for review June 18, 2025 19:25
@kevwhitt-hee kevwhitt-hee self-requested a review June 18, 2025 19:25
@rshrirohit rshrirohit merged commit 5d0610c into master Jun 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants