Skip to content

TD_5410_Adding config to the rate limiter so that we can environment, and add production logic to it. #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2025
Merged

TD_5410_Adding config to the rate limiter so that we can environment, and add production logic to it. #3300

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04054db
TD_5410_Adding config to the rate limiter so that we can conpare the …
ABSinhaa Jun 24, 2025
22a9fa2
TD_5410 Changes after discussion over moving the changs from class fi…
ABSinhaa Aug 12, 2025
195dfef
TD_5410 Changes after discussion, removing IConfiguration and Extra j…
ABSinhaa Aug 12, 2025
3745b6e
TD_5410 Reoving unwanted nuget packages, variable declarations and em…
ABSinhaa Aug 12, 2025
225b6ae
TD_5410_removing unwanted System from the namespace section.
ABSinhaa Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion DigitalLearningSolutions.Web/Middleware/DLSIPRateLimitMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
namespace DigitalLearningSolutions.Web.Middleware
{
using System;
using System.Threading.Tasks;
using AspNetCoreRateLimit;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using static Org.BouncyCastle.Math.EC.ECCurve;

public class DLSIPRateLimitMiddleware : IpRateLimitMiddleware
{
private readonly IConfiguration _configuration;
public DLSIPRateLimitMiddleware(
RequestDelegate next,
IProcessingStrategy processingStrategy,
IOptions<IpRateLimitOptions> options,
IConfiguration configuration,
IIpPolicyStore policyStore,
IRateLimitConfiguration config,
ILogger<IpRateLimitMiddleware> logger)
Expand All @@ -21,7 +26,9 @@ public DLSIPRateLimitMiddleware(
policyStore,
config,
logger)
{ }
{
_configuration = configuration;
}

public override Task ReturnQuotaExceededResponse(
HttpContext httpContext,
Expand Down
18 changes: 18 additions & 0 deletions DigitalLearningSolutions.Web/appSettings.UAT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,24 @@
"MaxBulkUploadRows": 200,
"LoginWithLearningHub": true
},
"IpRateLimiting": {
"EnableEndpointRateLimiting": false,
"StackBlockedRequests": false,
"RealIpHeader": "X-Real-IP",
"HttpStatusCode": 429,
"GeneralRules": [
{
"Endpoint": "post:/ForgotPassword",
"Period": "1m",
"Limit": 5
},
{
"Endpoint": "post:/Login",
"Period": "1m",
"Limit": 5
}
]
},
"LearningHubOpenAPIBaseUrl": "https://uks-learninghubnhsuk-openapi-test.azurewebsites.net",
"FreshdeskAPIConfig": {
"GroupId": "80000650208",
Expand Down
Loading