Skip to content

TD-5659-Modify the SQL query to retrieve distinct records and avoid records for which a request has already been sent. #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

TD-5659-Modify the SQL query to retrieve distinct records and avoid records for which a request has already been sent. #3303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions DigitalLearningSolutions.Data/DataServices/FrameworkDataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,7 +2066,7 @@ FROM FrameworkComments
public IEnumerable<CollaboratorDetail> GetReviewersForFrameworkId(int frameworkId)
{
return connection.Query<CollaboratorDetail>(
@"SELECT
@"SELECT DISTINCT
fc.ID,
fc.FrameworkID,
fc.AdminID,
Expand All @@ -2077,8 +2077,11 @@ public IEnumerable<CollaboratorDetail> GetReviewersForFrameworkId(int frameworkI
FROM FrameworkCollaborators fc
INNER JOIN AdminUsers AS au ON fc.AdminID = au.AdminID
LEFT OUTER JOIN FrameworkReviews ON fc.ID = FrameworkReviews.FrameworkCollaboratorID
WHERE (fc.FrameworkID = @FrameworkID) AND (FrameworkReviews.ID IS NULL) AND (fc.IsDeleted=0) OR
(fc.FrameworkID = @FrameworkID) AND (FrameworkReviews.Archived IS NOT NULL) AND (fc.IsDeleted=0)",
WHERE ((fc.FrameworkID = @FrameworkID) AND (FrameworkReviews.ID IS NULL) AND (fc.IsDeleted=0)) OR
((fc.FrameworkID = @FrameworkID) AND (FrameworkReviews.Archived IS NOT NULL) AND (fc.IsDeleted=0))
AND
(fc.ID Not in ( Select FrameworkCollaboratorID from FrameworkReviews where FrameworkID = @FrameworkID AND
FrameworkReviews.Archived IS NULL AND FrameworkCollaboratorID = fc.ID))",
new { frameworkId }
);
}
Expand Down
Loading