Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

@sherif-olaboye sherif-olaboye commented Jul 1, 2025

JIRA link

https://hee-tis.atlassian.net/browse/TD-3223

Description

I replaced the direct check for a null progress object and HTTP 410 Gone status code response with a conditional that also verifies whether the delegate still has current progress for the given progressId. If not, it redirects to a StatusCode action in the LearningSolutions controller with a 410 code parameter

I updated the test method Delegate_removal_for_delegate_with_no_active_progress_returns_not_found_result to reflect the new behavior, where the action now redirects to a 410 status code page instead of returning a NotFoundResult

Screenshots

image
image
image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@rshrirohit rshrirohit merged commit fe3cceb into DLS-Release-v1.2.2 Jul 8, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-3223-Showingconsole'404'errorwhenremovingthedelegatefromactivityandclickingbrowserbackbutton branch July 8, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants