Skip to content

Conversation

@kevwhitt-hee
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee commented Jul 4, 2025

JIRA link

TD-5759

Description

Registration answers and started date columns in original SP didn't match the model and were not mapping correctly. This migration fixes the SP to return the correct table schema.

Carried out more extensive testing of the result sets returned to confirm not only the data but the column names are identical.

Side-by-side comparisons show that for large result sets, the new approach is significantly faster but for small result sets (i.e. the testing centres), the new approach is significantly slower. On balance this is still a better approach, though.

Example results

TD-5759-ResultsComparisonIVTCtre374.xlsx


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@kevwhitt-hee kevwhitt-hee requested a review from rshrirohit July 4, 2025 07:11
@rshrirohit rshrirohit merged commit 202431b into DLS-Release-v1.2.1-Hotfix Jul 4, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-5759-RefactorSelfAssessmentReportQueries branch July 4, 2025 08:17
@kevwhitt-hee kevwhitt-hee restored the Develop/Fixes/TD-5759-RefactorSelfAssessmentReportQueries branch July 4, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants