TD-5816 Issue clearing 'confirmation requests' of 'optional competencies' if removed/added some other 'optional' competencies

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-5816

Description

Removed the logic in ManageOptionalCompetencies that deleted confirmation requests for optional competencies. Their confirmation status will now remain unchanged when optional competencies are added to or removed from a self-assessment

Screenshots

----- ### Developer checks (Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation

[rshrirohit]

The work done here undoes the work of ticket TD-5265. Please find an alternate solution. TD-5265 deletes the open confirmation request for optional proficiencies when the same optional prof has been removed.
Here, it is required that when any other prof is added or removed, the existing request is getting deleted.

[rshrirohit]

Rejecting this PR due to reason stated above.