Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Jul 30, 2025

JIRA link

TD-5535

Description

Undid the retirement logic code to bring in all the self assessments from the db.

Screenshots

No screenshots.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@ABSinhaa ABSinhaa marked this pull request as ready for review July 30, 2025 14:36
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rshrirohit rshrirohit merged commit b2322ba into DLS-Release-v1.2.3 Jul 31, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-5535_Retired_SelfAssessments_Show_Current_Activity branch July 31, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants