TD-6108 Updating ServiceFilter Logic To Exclude Other Areas

[rshrirohit]

JIRA link

TD-6108

Description

Updating servicefilter logic so that it works only on the self assessments and excludes other areas such as re-enrolment.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation

[rshrirohit]

@kevwhitt-hee instead of decorating each action method with servicefilter, we have changed the filter logic to only work on self assessment area. I have done dev testing and all URLs within a self assessment have similar URLs.
There are two exceptions for this -

1. Withdraw signoff link
2. Export (proficiencies) button

There are two things we can do-

1. Leave them be, these two things are not malicious activities
2. Include the urls for these two as hardcoded values similar to current work.

I appreciate that this isn't the best approach to solve this bug, but it is faster. Please feel free to reject the PR if you don't see it as a viable option.

[kevwhitt-hee]

Looks like a sensible compromise and implementation to me. Not ideal having a hard-coded path but shouldn't cause too many problems.