Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Sep 1, 2025

JIRA link

TD-5638

Description

Note: Advise to take DB or table backup before merging/executing this task.

Migration script added to:

  1. Make the SelfAssessmentSupervisorRoles foreign key field SelfAssessmentID nullable. Add two default roles 'Supervisor' and ‘Nominated Supervisor’ with NULL SelfAssessmentID.
  2. Update all CandidateAssessmentSupervisor records to appropriate generic SelfAssessmentSupervisorRoles records.
  3. Remove all existing roles from the table where SelfAssessmentID is not null

Scripts added to update stored procedures.
Backend SQL queries modified accordingly.
Changes made in UI, 'Assessor', 'Educator/Manager' have been changed to 'Supervisor', 'Nominated Supervisor' respectively.

Screenshots

image

Note: The section 'How to choose your supervisors' is being saved in the database table. 'Assessor', 'Educator/Manager' needs to be changed to 'Supervisor' and 'Nominated supervisor'.

Nominated supervisor title is being displayed in the activity supervisors list below

image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

…isor', 'Nominated Supervisor' respectively. Changes have been made to the view, backend, stored procedure.
@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review September 1, 2025 15:58
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Auldrin-Possa, we should script a database snapshot before running the updates in the migration. We have done this before in the migrations for the user account refactor.

@Auldrin-Possa
Copy link
Collaborator Author

snapshot

@kevwhitt-hee, Db snapshot is added. Please review.

@kevwhitt-hee kevwhitt-hee self-requested a review September 22, 2025 08:29
@kevwhitt-hee kevwhitt-hee merged commit 589f7df into DLS-Release-v1.2.4 Sep 22, 2025
3 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/feature/TD-5638-Remove-custom-administrator-titles branch September 22, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants