Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Sep 24, 2025

JIRA link

TD-6149

Description

Created a common view model - RetiringSelfAssessmentViewModel
Moved the retiring self-assessment check into a helper class
Made corresponding changes to the supervisor and Enrol controllers

Screenshots

image image

Developer checks

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review September 24, 2025 11:37
@kevwhitt-hee kevwhitt-hee merged commit 7b91511 into DLS-Release-v1.2.3 Sep 25, 2025
3 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/feature/TD-6149-Enrol-on-activity-retiring-self-assesment-Confirmation branch September 25, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants