TD-5563 Allow users to change the primary framework

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-5563

Description

Added ConfirmChangePrimaryFramework view to let users confirm make primary framework and add features to the framework.
Implemented GET and POST methods in ConfirmChangePrimaryFramework to render and submit the confirmation.
Added a Change Primary button to the SelectFrameworkSources view, enabling users to change their primary framework.

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation

[kevwhitt-hee]

This looks good, so far @sherif-olaboye. It looks like we are missing an implementation of the following requirement from the ticket:

We should allow the user to change the primary framework for their self assessment. When doing so, we should prompt them to ask which features of the new primary framework should be applied to the self assessment (using a similar interface to that implemented in TD-5562: Prompt users to ask which features of the framework they want to copy to the assessment

[sherif-olaboye]

This looks good, so far @sherif-olaboye. It looks like we are missing an implementation of the following requirement from the ticket:

We should allow the user to change the primary framework for their self assessment. When doing so, we should prompt them to ask which features of the new primary framework should be applied to the self assessment (using a similar interface to that implemented in TD-5562: Prompt users to ask which features of the framework they want to copy to the assessment

this is done

[rshrirohit]

@sherif-olaboye, this PR is targeting the Dev branch. I think it should be targeting the Lisbon branch. Could you please check and correct this?

[sherif-olaboye]

@sherif-olaboye, this PR is targeting the Dev branch. I think it should be targeting the Lisbon branch. Could you please check and correct this?

Done

[rshrirohit]

1. Can we please have some sort of division between the list of features to be copied and I agree checkbox? Right now it feels that the I agree checkbox is the continuation of the list

2. If I don't agree to this, the error shows on all list items. Can we please correct this?

[sherif-olaboye]

1. Can we please have some sort of division between the list of features to be copied and I agree checkbox? Right now it feels that the I agree checkbox is the continuation of the list

2. If I don't agree to this, the error shows on all list items. Can we please correct this?

Done

[rshrirohit]

Could you please address the inline comments?