- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
TD-6277 remove nhse tel frontend and replace with nhsuk frontend #3392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Phil-NHS
  wants to merge
  36
  commits into
  DLS-Release-v1.3.0
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Develop/Feature/TD-6277-Remove-NHSE-TEL-FRONTEND-and-replace-with-NHSUK-FRONTEND
  
      
      
   
  
    
  
  
  
 
  
      
    base: DLS-Release-v1.3.0
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 35 commits
      Commits
    
    
            Show all changes
          
          
            36 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5585cd2
              
                TD-6277 Yarn commands remove nhse-tel-frontend
              
              
                Phil-NHS 2eff957
              
                TD-6277 Change jest.config.ts
              
              
                Phil-NHS bdc267e
              
                TD-6277 Find replace nhse-tel-fronted to nhsuk-frontend for imports.
              
              
                Phil-NHS c256836
              
                TD-6277 Issue could be due the version itself revert to 9.1.0 runs cl…
              
              
                Phil-NHS 9f497f8
              
                TD-6277 NHSUK increase to 10.0.0 packages route change to dist as per…
              
              
                Phil-NHS 625df6e
              
                TD-6277 Following docs for nhsuk bundler but Details not detected htt…
              
              
                Phil-NHS 638edc8
              
                TD-6277 Remoivng tracking files of node nhsuk files because we are bu…
              
              
                Phil-NHS a91e869
              
                TD-6277 JSenabled and static assets  https://service-manual.nhs.uk/de…
              
              
                Phil-NHS c884763
              
                TD-6277 Remove meta tag for supporting no longer supported IE version…
              
              
                Phil-NHS 919f1f4
              
                TD-6277 Icon links added https://service-manual.nhs.uk/design-system/…
              
              
                Phil-NHS 25b8d5e
              
                TD-6277 nhsuk-action-link change https://service-manual.nhs.uk/design…
              
              
                Phil-NHS ac9bf36
              
                TD-6277 Replace back links used as back links https://github.com/nhsu…
              
              
                Phil-NHS 2c82cd4
              
                TD-6277 remove Details imports
              
              
                Phil-NHS 9b2a650
              
                TD-6277 Dist path and font size
              
              
                Phil-NHS f6cdf66
              
                TD-6277 Breadcrumb changes
              
              
                Phil-NHS 68c9258
              
                TD-6277 Pagination changes
              
              
                Phil-NHS 1ed23a1
              
                TD-6277 Card changes
              
              
                Phil-NHS 2576d00
              
                TD-6277 Radios and Checkboxes changes
              
              
                Phil-NHS c371ac2
              
                TD-6277 Frontend Meeting agreed change of nhsuk-back-link on divs
              
              
                Phil-NHS 119c57c
              
                TD-6277 Breadcrumb changes
              
              
                Phil-NHS 40d7cac
              
                TD-6277 nhsuk-back-link to nhsuk-link
              
              
                Phil-NHS 9e6ceaf
              
                TD-6277 Colour changes
              
              
                Phil-NHS 041eb2d
              
                TD-6277 Shade and Tint
              
              
                Phil-NHS 90e99d4
              
                TD-6277 color to colour renamings
              
              
                Phil-NHS abde8c1
              
                TD-6277 Polyfill seems not to exist and some changes show not support…
              
              
                Phil-NHS 4c92b6a
              
                TD-6277 Nonce console errors but not gmt.js
              
              
                Phil-NHS 5f30101
              
                TD-6277 Console errors manifest and favicon locations and rechecking …
              
              
                Phil-NHS bc41310
              
                TD-6277 Rereading docs find additional nhsuk-checkboxes nhsuk-radios
              
              
                Phil-NHS bb5de8e
              
                TD-6277 Body class
              
              
                Phil-NHS a7d719a
              
                TD-6277 NavBar Page Template Changes More does not push down in mobil…
              
              
                Phil-NHS f538492
              
                TD-6277 Border zero stop nav having space for More items when expanded
              
              
                Phil-NHS 2e1d040
              
                TD-6277 Header Text position and colour
              
              
                Phil-NHS 52875ff
              
                TD-6277 Footer template
              
              
                Phil-NHS fee6bfd
              
                TD-6277 Cancel cross svgs removed
              
              
                Phil-NHS d8a2dac
              
                TD-6277 Source controlled appsetting development json
              
              
                Phil-NHS d05af01
              
                Merge branch 'DLS-Release-v1.3.0' into Develop/Feature/TD-6277-Remove…
              
              
                Phil-NHS File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
        
          
          
            248 changes: 15 additions & 233 deletions
          
          248 
        
  DigitalLearningSolutions.Web/DigitalLearningSolutions.Web.csproj
  
  
      
      
   
        
      
      
    Large diffs are not rendered by default.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
| declare module 'nhse-tel-frontend/packages/components/header/header' { | ||
| declare module 'nhsuk-frontend/dist/nhsuk/components/header/header' { | ||
| export default function Header(): void; | ||
| } | ||
|  | ||
| declare module 'nhse-tel-frontend/packages/components/skip-link/skip-link' { | ||
| declare module 'nhsuk-frontend/dist/nhsuk/components/skip-link/skip-link' { | ||
| export default function SkipLink(): void; | ||
| } | ||
|  | ||
| declare module 'nhse-tel-frontend/packages/components/details/details' { | ||
| declare module 'nhsuk-frontend/dist/nhsuk/components/details/details' { | ||
| export default function Details(): void; | ||
| } | ||
|  | ||
| declare module 'nhse-tel-frontend/packages/components/radios/radios' { | ||
| declare module 'nhsuk-frontend/dist/nhsuk/components/radios/radios' { | ||
| export default function Radios(): void; | ||
| } | ||
|  | ||
| declare module 'nhse-tel-frontend/packages/components/checkboxes/checkboxes' { | ||
| declare module 'nhsuk-frontend/dist/nhsuk/components/checkboxes/checkboxes' { | ||
| export default function Checkboxes(): void; | ||
| } | ||
|  | ||
| declare module 'nhse-tel-frontend/packages/components/card/card' { | ||
| declare module 'nhsuk-frontend/dist/nhsuk/components/card/card' { | ||
| export default function Card(): void; | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,23 +1,11 @@ | ||
| // Components | ||
| import Header from 'nhse-tel-frontend/packages/components/header/header'; | ||
| import SkipLink from 'nhse-tel-frontend/packages/components/skip-link/skip-link'; | ||
| import Details from 'nhse-tel-frontend/packages/components/details/details'; | ||
| import Radios from 'nhse-tel-frontend/packages/components/radios/radios'; | ||
| import Checkboxes from 'nhse-tel-frontend/packages/components/checkboxes/checkboxes'; | ||
| import { initAll } from 'nhsuk-frontend'; | ||
|  | ||
| // Polyfills | ||
| import 'nhse-tel-frontend/packages/polyfills'; | ||
| import 'core-js/stable'; | ||
| import 'regenerator-runtime/runtime'; | ||
|  | ||
| // Initialize components | ||
| document.addEventListener( | ||
| 'DOMContentLoaded', | ||
| () => { | ||
| Details(); | ||
| Header(); | ||
| SkipLink(); | ||
| Radios(); | ||
| Checkboxes(); | ||
| }, | ||
| ); | ||
| document.addEventListener('DOMContentLoaded', () => { | ||
| initAll(); | ||
| }); | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            2 changes: 1 addition & 1 deletion
          
          2 
        
  DigitalLearningSolutions.Web/Scripts/spec/learningMenu/fullscreen.spec.ts
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -658,7 +658,7 @@ public void Configure(IApplicationBuilder app, IMigrationRunner migrationRunner, | |
| endpoints.MapControllerRoute("default", "{controller=Home}/{action=Index}") | ||
| ); | ||
|  | ||
| migrationRunner.MigrateUp(); | ||
| migrationRunner.MigrateUp(); | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file has only whitespace change. We understand that you might have used the formatter that has created these, but please could we undo them, please? | ||
| } | ||
|  | ||
| private Task RedirectToLogin(RedirectContext<CookieAuthenticationOptions> context) | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove comments like these, please?