Skip to content

Conversation

@Phil-NHS
Copy link
Collaborator

@Phil-NHS Phil-NHS commented Apr 7, 2025

PR Template

TODO: About

  • SO FAR no js controllers are not going to be covered in testing in the package it will be done by how used in LH
    But in future we could simulate them with just an api with stock response or find a programatic way, or build a hosted environment.
    The gh-page are pure wasm so not supported for nojs

TODO: This is just replicating LH for now ... ideas

  • Link to replicated component
  • Link design confluence if coming from design
  • Tick box for JS
  • If testers find an issue create an automated test of what they did, even potentially with playright record test functionality

JIRA link

TD-####

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

semantic-release-bot and others added 6 commits April 7, 2025 14:33
# [1.3.0-feat-pr-template-release.1](v1.2.41...v1.3.0-feat-pr-template-release.1) (2025-04-07)

### Bug Fixes

* **centalising yaml:** yaml ([8334d02](8334d02))
* **coke:** pepse ([0079810](0079810))
* **commit history git ui commits break semver:** fix semver ([a6ef9e3](a6ef9e3))
* **dddd:** gggg ([9295645](9295645))
* **eurggh:** ee ([5c7212d](5c7212d))
* **goes:** nothing ([4a02265](4a02265))
* **go:** go ([1a3faf0](1a3faf0))
* **more debugging:** jhfhf ([9d934f9](9d934f9))
* **post version reset does it work:** sdh ([08a55c1](08a55c1))
* **spacing:** ffhf ([67bbd20](67bbd20))
* **token:** unlikely ([182cd83](182cd83))
* **ttt:** fgh ([41229ff](41229ff))
* **where really is the error:** error ([65971d8](65971d8))
* **yml:** still trying to fix ([0f7ad99](0f7ad99))

### Features

* **123:** feat ([c525139](c525139))
* **branch regulation:** ci really ([2e9d50a](2e9d50a))
* **cale:** kale ([e302d08](e302d08))
* **cant handle merges so pull before push:** gogog ([9893d8c](9893d8c))
* **cc:** ffff ([71c1e42](71c1e42))
* **channel:** isit ([62e0204](62e0204))
* **ddd:** ddd ([d6331f1](d6331f1))
* **desperate:** without debug as new weird error ([b653585](b653585))
* **dev:** dev ([17468c7](17468c7))
* **dfsd:** looop ([320ea67](320ea67))
* **dggg:** gggg ([101fea4](101fea4))
* **gogog:** gogog ([7b6f5f9](7b6f5f9))
* **hmm:** ok meb ([099cf76](099cf76))
* **just try:** sdf ([04cd1c8](04cd1c8))
* **pain:** ahhhh ([cafc6b5](cafc6b5))
* **plz:** plz ([4420cae](4420cae))
* **sdfd:** sdfsdf ([a25b40f](a25b40f))
* **sd:** ff is release intearing ([85d1d71](85d1d71))
* **semver still:** lets go ([f2f87cd](f2f87cd))
* **seperate yml pr release dev:** gogogo ([6b7d1cb](6b7d1cb))
* **sfsf:** sdfsdf ([48f99a1](48f99a1))
* **should work:** please ([bfb52e1](bfb52e1))
* **slashless:** googog ([11a8e5b](11a8e5b))
* **tags been set elsewhere may fix itself:** dsfjb ([1411625](1411625))
* **worked now try channel:** channel ([0ae18e6](0ae18e6))
@Phil-NHS Phil-NHS requested a review from binon April 7, 2025 14:51
@Phil-NHS Phil-NHS self-assigned this Apr 7, 2025
@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 14:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

Package.BlazorComponentLibrary/Components/SimpleCounter.razor:4

  • [nitpick] The updated button text 'A Build (@currentCount)' is unclear. Consider using a more descriptive label like 'Increment (@currentCount)' to better convey its purpose.
   A Build (@currentCount)

.github/workflows/release.yml:116

  • The variable name was corrected by removing an extraneous 'd', which appears to be a fix; please verify that this new output key aligns with the rest of the workflow configuration.
if: ${{ steps.set-semantic-version.outputs.semantic-release-version  != '' }}  # Only run if there's a version

CHANGELOG.md:6

  • The word 'centalising' appears to be a spelling mistake; consider correcting it to 'centralising'.
* **centalising yaml:** yaml ([8334d02](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/8334d02))

@Phil-NHS Phil-NHS enabled auto-merge (squash) April 7, 2025 15:14
Copy link
Contributor

@binon binon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can see the template Phil

@Phil-NHS Phil-NHS merged commit 296f0bd into master Apr 7, 2025
14 of 15 checks passed
@Phil-NHS Phil-NHS deleted the feat-pr-template-release branch April 8, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants