Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
name: Pull Request Checks
on:
pull_request:
# branches:
# - '**'


on: pull_request
jobs:

branch-name-check:
name: Enforce Branch Name Convention
runs-on: ubuntu-latest
Expand All @@ -27,6 +25,7 @@ jobs:
#continue-on-error: true

commitlint:
name: commitlint
# qqqq repo will need branch protection rules and PR Template
runs-on: ubuntu-latest
if: success() || failure()
Expand All @@ -41,6 +40,7 @@ jobs:


gitguardian-scan:
name: gitguardian
runs-on: ubuntu-latest
if: success() || failure()
steps:
Expand All @@ -53,6 +53,7 @@ jobs:
#continue-on-error: true # we dont want secrets going further and the keys need to be changed if this is triggered

Unit-Tests:
name: todo unit tests
runs-on: ubuntu-latest
if: success() || failure()
steps:
Expand All @@ -62,6 +63,7 @@ jobs:


E2E-Tests:
name: todo e2e tests
runs-on: ubuntu-latest
if: success() || failure()
steps:
Expand All @@ -70,9 +72,27 @@ jobs:
#continue-on-error: true

Code-Coverage:
name: code coverage
runs-on: ubuntu-latest
if: success() || failure()
steps:
- name: Code Coverage
run: echo "TODO Code Coverage"
#continue-on-error: true

All-Checks-Passed:
name: all checks passed
runs-on: ubuntu-latest
needs:
- branch-name-check
- commitlint
- gitguardian-scan
- Unit-Tests
- E2E-Tests
- Code-Coverage
if: ${{ success() }}
steps:
- name: all checks passed steps
run: echo "allow all checks to run incase multiple fails then fail here"


13 changes: 3 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
# [9.1.0](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.0.0...v9.1.0) (2025-04-15)
## [9.1.1-fix-pr-release-yml.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.1.0...v9.1.1-fix-pr-release-yml.1) (2025-04-15)


### Features
### Bug Fixes

* **pr and rel:** to master ([25d0f7b](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/25d0f7bd4be8deebf4ac61922e2fb039ccf3b705))

# [9.1.0-feat-version-work-on-branch-maybe.1](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/compare/v9.0.0...v9.1.0-feat-version-work-on-branch-maybe.1) (2025-04-15)


### Features

* **pr and rel:** to master ([25d0f7b](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/25d0f7bd4be8deebf4ac61922e2fb039ccf3b705))
* **pr check:** check ([ae4bbad](https://github.com/TechnologyEnhancedLearning/GitPageBlazorWASM/commit/ae4bbadd17de402900431967692b1d2792023318))