TD-6391: Modified the calls to update elfh Hub DB UserTbl records during authentication

Author: ArunimaGeorge

LearningHub.Nhs.UserApi.Services/ElfhUserService.cs

@@ -231,21 +231,22 @@ public async Task RecordSuccessfulSigninAsync(int id, CancellationToken token =
         {
             var user = await this.elfhUserRepository.GetByIdAsync(id);
 
-            user.LoginTimes++;
-            user.PasswordLifeCounter = 0;
-            user.SecurityLifeCounter = 0;
+            if (user.PasswordLifeCounter != 0 || user.SecurityLifeCounter != 0)
+            {
+                user.PasswordLifeCounter = 0;
+                user.SecurityLifeCounter = 0;
 
-            await this.elfhUserRepository.UpdateAsync(id, user);
+                await this.elfhUserRepository.UpdateAsync(id, user);
 
-            await this.InvalidateElfhUserCacheAsync(user.Id, user.UserName, token);
+                await this.InvalidateElfhUserCacheAsync(user.Id, user.UserName, token);
+            }
         }
 
         /// <inheritdoc/>
         public async Task RecordUnsuccessfulSigninAsync(int id, CancellationToken token = default)
         {
             var user = await this.elfhUserRepository.GetByIdAsync(id);
 
-            user.LoginTimes++;
             user.PasswordLifeCounter++;
 
             await this.elfhUserRepository.UpdateAsync(id, user);