-
Notifications
You must be signed in to change notification settings - Fork 1
Retrival of moodle user #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevwhitt-hee @binon I feel it will be good if we can create a new endpoint either in User API/Open API to handle Moodle user validation Logic. in future if need to use same Moodle user validation for any other logics in LH we can use this endpoint .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnjuJose011 , this is POC when we move to actual piece of work we need to refactor and move to Model solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Anju's suggestion but also that we can wait for this to become a production change before refactoring. @binon, is it worth drafting some tickets so that we can capture some of this detail while we wait for finalised designs? It feels like we have a pretty good idea of where this work is going, now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this model class to LH Model Repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnjuJose011 , this is POC when we move to actual piece of work we need to refactor and move to Model solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Anju's suggestion but also that we can wait for this to become a production change before refactoring. @binon, is it worth drafting some tickets so that we can capture some of this detail while we wait for finalised designs? It feels like we have a pretty good idea of where this work is going, now...
Merging my Moodle changes to RC and will document that model changes in a ticket, so that we refactor it when we plan prod. |
JIRA link
This is linked with
https://hee-tis.atlassian.net/browse/TD-5284
Description
Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.
Screenshots
Attach screenshots on mobile, tablet and desktop.
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: