Skip to content

Conversation

binon
Copy link
Collaborator

@binon binon commented Apr 11, 2025

JIRA link

This is linked with
https://hee-tis.atlassian.net/browse/TD-5284

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevwhitt-hee @binon I feel it will be good if we can create a new endpoint either in User API/Open API to handle Moodle user validation Logic. in future if need to use same Moodle user validation for any other logics in LH we can use this endpoint .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnjuJose011 , this is POC when we move to actual piece of work we need to refactor and move to Model solution

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Anju's suggestion but also that we can wait for this to become a production change before refactoring. @binon, is it worth drafting some tickets so that we can capture some of this detail while we wait for finalised designs? It feels like we have a pretty good idea of where this work is going, now...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this model class to LH Model Repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnjuJose011 , this is POC when we move to actual piece of work we need to refactor and move to Model solution

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Anju's suggestion but also that we can wait for this to become a production change before refactoring. @binon, is it worth drafting some tickets so that we can capture some of this detail while we wait for finalised designs? It feels like we have a pretty good idea of where this work is going, now...

@AnjuJose011 AnjuJose011 self-requested a review April 14, 2025 07:30
@binon
Copy link
Collaborator Author

binon commented Apr 14, 2025

Merging my Moodle changes to RC and will document that model changes in a ticket, so that we refactor it when we plan prod.

@binon binon merged commit a9a7009 into RC Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants