Skip to content

Conversation

frank-hee
Copy link
Contributor

@frank-hee frank-hee commented Jul 31, 2025

JIRA link

TD-4916

Description

Moved all Auth .nhsuk classes from layout.scss and common.scss into nhsuk-overrides.scss

This resulted in a lack of need for layout.scss which has been deleted

Two layouts updated to remove links to layout.css and add links to nhsuk-overrides.css

Commented nhsuk-overrides and moved some classes around to make for easier reading.

Screenshots

image image image image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@frank-hee frank-hee self-assigned this Jul 31, 2025
@frank-hee frank-hee added the enhancement New feature or request label Jul 31, 2025
@AnjuJose011 AnjuJose011 merged commit e395ca7 into RC Aug 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants