Skip to content

TD-4180: Moved client side validations to server side. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes to CI
merged 1 commit into from
Dec 18, 2024
Merged

TD-4180: Moved client side validations to server side. #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Auth/LearningHub.Nhs.Auth/Views/Account/LHLogin.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
@{
ViewData["Title"] = "Login";
ViewData["Layout"] = "learninghub/_Layout";
ViewData["DisableValidation"] = true;
// OpenAthens url needs to makes sure that the return to WebUI first hits the authorisationrequired endpoint,
// which contains it's own redirect to within the UI.
// If a return url is specified we want to use it for the authorisationrequired original url
Expand Down
15 changes: 9 additions & 6 deletions Auth/LearningHub.Nhs.Auth/Views/Shared/_ValidationScriptsPartial.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<environment include="Development">
<script src="~/lib/jquery-validation/dist/jquery.validate.js"></script>
<script src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js"></script>
</environment>
<environment exclude="Development">
@if (!ViewData["DisableValidation"]?.Equals(true) ?? true)
{
<environment include="Development">
<script src="~/lib/jquery-validation/dist/jquery.validate.js"></script>
<script src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js"></script>
</environment>
<environment exclude="Development">
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery-validate/1.17.0/jquery.validate.min.js"
asp-fallback-src="~/lib/jquery-validation/dist/jquery.validate.min.js"
asp-fallback-test="window.jQuery && window.jQuery.validator"
Expand All @@ -15,7 +17,8 @@
crossorigin="anonymous"
integrity="sha256-9GycpJnliUjJDVDqP0UEu/bsm9U+3dnQUH8+3W10vkY=">
</script>
</environment>
</environment>
}
<script type="text/javascript">
// Add/remove class 'input-validation-error' to the div containing the control with error

Expand Down
Loading