Skip to content

Commit b0d4657

Browse files
Merge pull request #263 from TechnologyEnhancedLearning/Develop/Features/TD-2954-My-Learning-Page-Improvements-in-Performance
TD-2954: 1. Filter issue with combination of Completed and eLearning fixed. Filter tag text and checkbox label changed For Completed and In Progress
2 parents fb55101 + d10b84b commit b0d4657

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

LearningHub.Nhs.WebUI/Models/MyLearningViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ public List<CheckboxListItemViewModel> StatusFilterCheckbox()
184184
{
185185
var checkboxes = new List<CheckboxListItemViewModel>()
186186
{
187-
new CheckboxListItemViewModel("Complete", "Complete", null),
188-
new CheckboxListItemViewModel("Incomplete", "InProgress", null),
187+
new CheckboxListItemViewModel("Complete", "Completed", null),
188+
new CheckboxListItemViewModel("Incomplete", "In Progress", null),
189189
new CheckboxListItemViewModel("Passed", "Passed", null),
190190
new CheckboxListItemViewModel("Failed", "Failed", null),
191191
new CheckboxListItemViewModel("Downloaded", "Downloaded", null),

LearningHub.Nhs.WebUI/Views/MyLearning/_filterSummary.cshtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@
5353
}
5454
@if (Model.Complete)
5555
{
56-
filtersummary = filtersummary + $" <strong class='nhsuk-tag'>Complete</strong>";
56+
filtersummary = filtersummary + $" <strong class='nhsuk-tag'>Completed</strong>";
5757
}
5858
@if (Model.Incomplete)
5959
{
60-
filtersummary = filtersummary + $" <strong class='nhsuk-tag'>InProgress</strong>";
60+
filtersummary = filtersummary + $" <strong class='nhsuk-tag'>In Progress</strong>";
6161
}
6262
@if (Model.Passed)
6363
{

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLearningActivities.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,8 @@ FROM (
245245
)
246246
)
247247
)
248-
248+
OR
249+
([Res].[ResourceTypeId] IN (6) AND [ResourceActivity].[ActivityStatusId] = 3)
249250
--OR
250251
--(
251252
-- ([Res].[ResourceTypeId] IN (1,5,10,12) AND [ResourceActivity].[ActivityStatusId] = 3)

WebAPI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLearningActivitiesCount.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,8 @@ FROM (
160160
)
161161
)
162162
)
163+
OR
164+
([Res].[ResourceTypeId] IN (6) AND [ResourceActivity].[ActivityStatusId] = 3)
163165

164166
--OR
165167
--(

0 commit comments

Comments
 (0)