Merge pull request #262 from TechnologyEnhancedLearning/Develop/Fixes/TD-3955-Certificate-not-unlocking-for-user

sarathlal-sarangadharan · web-flow · commit fb55101bb8a4 · 2024-04-08T10:13:49.000+01:00
TD-3955: eLearning with Passed type is also included when the user completes the learning and exit without proper closure
diff --git a/LearningHub.Nhs.WebUI/Controllers/Api/ScormController.cs b/LearningHub.Nhs.WebUI/Controllers/Api/ScormController.cs
@@ -260,7 +260,7 @@ private async Task<bool> Commit(SCO scoObject)
 
                 // Persist update.
                 await this.activityService.UpdateScormActivityAsync(scoObject);
-                if (scoObject.LessonStatusId == 3)
+                if (scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Completed) || scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Passed))
                 {
                     await this.activityService.CompleteScormActivity(scoObject);
                 }

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ private async Task<bool> Commit(SCO scoObject)`
`260`	`260`
`261`	`261`	`// Persist update.`
`262`	`262`	`await this.activityService.UpdateScormActivityAsync(scoObject);`
`263`		`- if (scoObject.LessonStatusId == 3)`
	`263`	`+ if (scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Completed) \|\| scoObject.LessonStatusId == ScormLessionStatus.ActivityStatusId(ScormLessionStatus.Passed))`
`264`	`264`	`{`
`265`	`265`	`await this.activityService.CompleteScormActivity(scoObject);`
`266`	`266`	`}`