Skip to content

TD-5179: Fixed focus issue on My bookmarks screen #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge Release v1.3.1 englishl ivy to RC
merged 1 commit into from
Mar 13, 2025
Merged

TD-5179: Fixed focus issue on My bookmarks screen #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions LearningHub.Nhs.WebUI/Styles/nhsuk/pages/bookmark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,23 @@ td.col-type {
tr.bookmark-item:hover td {
background-color: $nhsuk-white;
}
.my-bookmark-btn:focus {
outline: none;
text-decoration: none !important;
color: $nhsuk-black !important;
background-color: $nhsuk-yellow !important;
box-shadow: 0 -2px $govuk-focus-highlight-yellow, 0 4px $nhsuk-black;
}

.my-bookmark-btn:hover {
outline: none;
text-decoration: none !important;
}

.my-bookmark-btn {
transition: none !important;
border-radius: 0 !important;
}

@media (min-width: 768px) {

Expand Down
10 changes: 5 additions & 5 deletions LearningHub.Nhs.WebUI/Views/Bookmark/_BookmarkAction.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<span class="action-link-chevron @(Model.IsFirst? "empty" : "")">
@if (Model.IsFirst == false)
{
<button name="action" value="moveup" class="btn btn-link action-link" title="Move up" aria-label="Move up">
<button name="action" value="moveup" class="btn btn-link action-link my-bookmark-btn" title="Move up" aria-label="Move up">
<i class="fa-solid fa-chevron-up fa-sm"></i>
</button>
}
Expand All @@ -15,25 +15,25 @@
<span class="action-link-chevron @(Model.IsLast? "empty" : "")">
@if (Model.IsLast == false)
{
<button name="action" value="movedown" class="btn btn-link action-link" title="Move down" aria-label="Move down">
<button name="action" value="movedown" class="btn btn-link action-link my-bookmark-btn" title="Move down" aria-label="Move down">
<i class="fa-solid fa-chevron-down fa-sm"></i>
</button>
}
</span>

<span class="action-link-rename">
<button name="action" value="rename" class="btn btn-link action-link" title="Rename">Rename</button>
<button name="action" value="rename" class="btn btn-link action-link my-bookmark-btn" title="Rename">Rename</button>
</span>

<span class="action-link-move">
@if (Model.IsFolder == false)
{
<button name="action" value="move" class="btn btn-link action-link" title="Move">Move</button>
<button name="action" value="move" class="btn btn-link action-link my-bookmark-btn" title="Move">Move</button>
}
</span>

<span class="action-link-delete">
<button name="action" value="delete" class="btn btn-link action-link" title="Delete">Delete</button>
<button name="action" value="delete" class="btn btn-link action-link my-bookmark-btn" title="Delete">Delete</button>
</span>
</form>
</div>
Loading