Skip to content

Conversation

@binon
Copy link
Collaborator

@binon binon commented Apr 11, 2025

JIRA link

TD- 5285 retrieve enrolled courses from moodle for user and display in LH

https://hee-tis.atlassian.net/browse/TD-5285

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this model class to LH Model Repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevwhitt-hee @binon as part of https://hee-tis.atlassian.net/browse/TD-5496 Oluwtobi currently replacing all Web API calls with Open API. it will be good if we can create a new endpoint in Open API to retrieve enrolled Moodle courses for the logged in user.

@AnjuJose011 AnjuJose011 self-requested a review April 14, 2025 08:26
@binon
Copy link
Collaborator Author

binon commented Apr 14, 2025

Merging my Moodle changes to RC and will document that model changes in a ticket, so that we refactor it when we plan prod.

@binon binon merged commit 854eb7f into RC Apr 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants