Skip to content

removed the hardcoded url in moodle entrolled course #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes into CI
merged 1 commit into from
Apr 22, 2025
Merged

removed the hardcoded url in moodle entrolled course #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LearningHub.Nhs.WebUI/Services/MoodleHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class MoodleHttpClient : IMoodleHttpClient, IDisposable
public MoodleHttpClient(HttpClient httpClient, IConfiguration config)
{
this.httpClient = httpClient;
this.moodleAPIBaseUrl = config["MoodleAPIConfig:BaseUrl"];
this.moodleAPIBaseUrl = config["MoodleAPIConfig:BaseUrl"] + "webservice/rest/server.php";
this.moodleAPIMoodleWSRestFormat = config["MoodleAPIConfig:MoodleWSRestFormat"];
this.moodleAPIWSToken = config["MoodleAPIConfig:WSToken"];
}
Expand Down
10 changes: 6 additions & 4 deletions LearningHub.Nhs.WebUI/Views/Home/_CourseEnrolled.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@
@using LearningHub.Nhs.WebUI.Extensions
@using LearningHub.Nhs.WebUI.Helpers
@model MoodleCourseResponseViewModel
@inject Microsoft.Extensions.Configuration.IConfiguration Configuration;

@{
bool providerExists = false;
string cardStyle = "card-provider-details--blank";

string GetUrl(int courseId)
string GetMoodleCourseUrl(int courseId)
{
string host = $"http://localhost";
var apiBaseUrl = Configuration["MoodleAPIConfig:BaseUrl"];
string path = $"course/view.php";
string returnUrl = $@"{host}/{path}?id={courseId}";
string returnUrl = $@"{apiBaseUrl}/{path}?id={courseId}";

return returnUrl;
}
Expand Down Expand Up @@ -47,7 +49,7 @@

<div class="nhsuk-card__content dashboard-card-content">
<h3 class="nhsuk-card__heading nhsuk-heading-m">
<a class="nhsuk-card__link" href="@GetUrl(Model.Id.Value)">@Model.DisplayName</a>
<a class="nhsuk-card__link" href="@GetMoodleCourseUrl(Model.Id.Value)">@Model.DisplayName</a>
</h3>
<div class="nhsuk-card__description dashboard-card-body">

Expand Down
Loading