Skip to content

TD-3727- Unrestricted file upload- SIT comments #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes into CI
merged 1 commit into from
Apr 29, 2025
Merged

TD-3727- Unrestricted file upload- SIT comments #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/Content.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,8 @@
v-model.trim="currentPassword"
placeholder="Current password"
@blur="$v.currentPassword.$touch()"
v-bind:class="{ 'input-validation-error': $v.currentPassword.$error}">
v-bind:class="{ 'input-validation-error': $v.currentPassword.$error}"
@keydown.enter="submitPassword">
</div>

<div class="row" v-if="showError">
Expand Down
4 changes: 2 additions & 2 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/fileUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@
}
}
else {
this.$emit('childfileuploaderror', FileErrorTypeEnum.Custom, 'There was a problem uploading this file to the Learning Hub. The .zip file you tried to upload was empty.');
this.$emit('childfileuploaderror', FileErrorTypeEnum.InvalidType, 'We do not support this file type on the Learning Hub.');
}
}
this.uploading = false;
Expand All @@ -263,7 +263,7 @@
this.$emit('childfileuploaderror', FileErrorTypeEnum.Custom, 'There was a problem uploading this file to the Learning Hub. Please try again and if it still does not upload, contact the support team.');
}
else {
this.$emit('childfileuploaderror', FileErrorTypeEnum.Custom, 'There was a problem uploading this file to the Learning Hub. The .zip file you tried to upload was empty.');
this.$emit('childfileuploaderror', FileErrorTypeEnum.InvalidType, 'We do not support this file type on the Learning Hub.');
}
self.processing = false;
self.uploading = false;
Expand Down
Loading