Skip to content

Conversation

@binon
Copy link
Collaborator

@binon binon commented Jun 19, 2025

JIRA link

TD-####

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR pins explicit package versions across projects, disables centralized package version management, and updates hosting settings in the API’s web.config.

  • Pinned package references by adding Version attributes in numerous .csproj files
  • Disabled central package version management in Directory.Packages.props
  • Updated web.config to point at a local EXE path and added development environment variables

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

File Description
*.csproj (various) Added explicit Version attributes to package references
Directory.Packages.props Set <ManagePackageVersionsCentrally> to false
WebAPI/LearningHub.Nhs.API/web.config Changed aspNetCore processPath and added env vars
Comments suppressed due to low confidence (1)

Directory.Packages.props:5

  • [nitpick] Disabling centralized version management can lead to inconsistent package versions across projects. Keep this setting enabled or ensure all projects are updated in lockstep.
		<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>

<handlers>
<add name="aspNetCore" path="*" verb="*" modules="AspNetCoreModuleV2" resourceType="Unspecified" />
</handlers>
<aspNetCore processPath="bin\x64\Debug\net8.0\LearningHub.Nhs.Api.exe" arguments="" stdoutLogEnabled="false" stdoutLogFile=".\logs\stdout" hostingModel="InProcess">
Copy link

Copilot AI Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The processPath is pointing to the Debug output folder, which will not exist after publishing. Consider using the published DLL with dotnet MyApi.dll or updating the path to the published executable.

Suggested change
<aspNetCore processPath="bin\x64\Debug\net8.0\LearningHub.Nhs.Api.exe" arguments="" stdoutLogEnabled="false" stdoutLogFile=".\logs\stdout" hostingModel="InProcess">
<aspNetCore processPath="dotnet LearningHub.Nhs.Api.dll" arguments="" stdoutLogEnabled="false" stdoutLogFile=".\logs\stdout" hostingModel="InProcess">

Copilot uses AI. Check for mistakes.
@AnjuJose011 AnjuJose011 merged commit 3570bb3 into RC Jun 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants