Skip to content

Conversation

@frank-hee
Copy link
Contributor

JIRA link

TD-4916

Description

Moved .nhsuk class overrides to LearningHub.Nhs.WebUI\Styles\nhsuk\nhsuk.scss
Removed those that were no longer needed
Commented to give indications of use
Majority of overrides are for the header which is being redesigned soon

Screenshots

No visible difference in appearance


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@frank-hee frank-hee requested a review from AnjuJose011 July 11, 2025 11:24
@frank-hee frank-hee self-assigned this Jul 11, 2025
@frank-hee frank-hee added the enhancement New feature or request label Jul 11, 2025
@frank-hee frank-hee merged commit 3dbcd20 into RC Jul 14, 2025
4 checks passed
AnjuJose011 added a commit that referenced this pull request Jul 18, 2025
…lop/Fixes/TD-4916-nhsuk-override-consolidation"

This reverts commit 3dbcd20, reversing
changes made to a383b72.
AnjuJose011 added a commit that referenced this pull request Jul 18, 2025
…elop/Fixes/TD-4916-nhsuk-override-consolidation"

This reverts commit 7c353e0.
AnjuJose011 added a commit that referenced this pull request Jul 22, 2025
…lop/Fixes/TD-4916-nhsuk-override-consolidation"

This reverts commit 3dbcd20, reversing
changes made to a383b72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants