Skip to content

TD-4038: Message updated for empty search in AllCatalogues and main search pages #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

TD-4038: Message updated for empty search in AllCatalogues and main search pages #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions LearningHub.Nhs.WebUI/Views/Catalogue/AllCatalogueSearch.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

var queryParams = QueryHelpers.ParseQuery(Context.Request.QueryString.ToString());
var hasSearchTerm = queryParams.ContainsKey("term");
var searchTerm = hasSearchTerm ? queryParams["term"].ToString() : null;
var searchTerm = hasSearchTerm ? queryParams["term"].ToString().Trim() : null;
string cardStyle = "card-provider-details--blank";
var pageSize = this.ViewBag.PageSize;
}
Expand All @@ -22,9 +22,9 @@
var parms = new Dictionary<string, string> { { "term", searchTerm } };
<vc:back-link asp-controller="Catalogue" asp-action="GetAllCatalogue" link-text="Back to A-Z of catalogues" />
}
<h1 class="nhsuk-u-margin-bottom-5">
@(hasSearchTerm ? $"Search results for {searchTerm}" : "All catalogues")
</h1>
<h1 class="nhsuk-u-margin-bottom-5">
Search results @(!string.IsNullOrEmpty(searchTerm) ? "for " + searchTerm : string.Empty)
</h1>

<div class="nhsuk-grid-row">
<div id="searchTab" class="search-page">
Expand Down Expand Up @@ -139,7 +139,7 @@
{
<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-full">
<h2 class="nhsuk-heading-l">No results found for @searchTerm</h2>
<h2 class="nhsuk-heading-l">No results found @(!string.IsNullOrEmpty(searchTerm) ? "for " + searchTerm : string.Empty)</h2>
<p>You could try:</p>
<ul class="nhsuk-list nhsuk-list--bullet">
<li>checking your spelling</li>
Expand Down
11 changes: 5 additions & 6 deletions LearningHub.Nhs.WebUI/Views/Search/Index.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@

<div class="search-page">
<div class="nhsuk-width-container app-width-container">

<h1 class="nhsuk-u-margin-top-5 nhsuk-u-margin-bottom-6">
Search results for @Model.SearchString
</h1>

<h1 class="nhsuk-u-margin-top-5 nhsuk-u-margin-bottom-6">
Search results @(!string.IsNullOrEmpty(Model.SearchString) ? "for " + Model.SearchString : string.Empty)
</h1>

<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-two-thirds">
@await Html.PartialAsync("_SearchBar", @Model.SearchString)
Expand Down Expand Up @@ -48,7 +47,7 @@
{
<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-full">
<h2 class="nhsuk-heading-l">No results found for @Model.SearchString</h2>
<h2 class="nhsuk-heading-l">No results found @(!string.IsNullOrEmpty(Model.SearchString) ? "for " + Model.SearchString : string.Empty)</h2>
<p>You could try:</p>
<ul class="nhsuk-list nhsuk-list--bullet">
<li>checking your spelling</li>
Expand Down
Loading