Skip to content

Conversation

@ArunimaGeorge
Copy link
Contributor

@ArunimaGeorge ArunimaGeorge commented Sep 27, 2024

JIRA link

TD-4704

Description

Issue fixed for showing 'elfh' logo on catalogue details page accessed from the dashboard and from the search results page. Also the provider name is now shown on the catalogue tray of my accessed learning.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…ails' screen when accessed 'Search' & 'Catalogue cards' screens
@ArunimaGeorge ArunimaGeorge merged commit b76051d into releases/LHBegonia Sep 27, 2024
2 checks passed
@ArunimaGeorge ArunimaGeorge deleted the Develop/Fixes/TD-4704-LH-Live-Issue-not-showing-the-'elfh'-logo-on-'Catalogue-details'-screen-when-accessed-'Search'-&-'Catalogue-cards'-screens branch September 27, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants