Skip to content

TD-4432: Issue with the 'Keywords' when given in upper case changed t… #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

TD-4432: Issue with the 'Keywords' when given in upper case changed t… #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/components/KeyWordsEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
return this.resourceDetails.resourceVersionId;
},
newKeywordTrimmed(): string {
return this.newKeyword?.trim().replace(/ +(?= )/g, '').toLowerCase();
return this.newKeyword?.trim().replace(/ +(?= )/g, '');
},
},
methods: {
Expand All @@ -77,9 +77,9 @@
},
async addKeyword() {
if (this.newKeyword && this.newKeywordTrimmed.length > 0) {
let allTrimmedKeyword = this.newKeywordTrimmed.toLowerCase().split(',');
let allTrimmedKeyword = this.newKeywordTrimmed.split(',');
allTrimmedKeyword = allTrimmedKeyword.filter(e => String(e).trim());
if (!this.resourceDetails.resourceKeywords.find(_keyword => allTrimmedKeyword.includes(_keyword.keyword.toLowerCase()))) {
if (!this.resourceDetails.resourceKeywords.find(_keyword => allTrimmedKeyword.includes(_keyword.keyword))) {
for (var i = 0; i < allTrimmedKeyword.length; i++) {
let item = allTrimmedKeyword[i];
if (item.length > 0 && item.length <= 50) {
Expand Down
8 changes: 4 additions & 4 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/ContentCommon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@
!Boolean(this.$route.query.initialCreate); // or if the user is editing an existing draft (initialCreate=false)
},
newKeywordTrimmed(): string {
return this.newKeyword?.trim().replace(/ +(?= )/g, '').toLowerCase();
return this.newKeyword?.trim().replace(/ +(?= )/g, '');
},
showProviders(): boolean {
if (!this.$store.state.userProviders) {
Expand Down Expand Up @@ -393,7 +393,7 @@
this.keywords = this.resourceDetail.resourceKeywords.map(obj => {
let kw = new KeywordModel();
kw.id = obj.id;
kw.keyword = obj.keyword.toLowerCase();
kw.keyword = obj.keyword;
return kw;
});
if (this.resourceDetail.resourceProviderId > 0) {
Expand Down Expand Up @@ -532,9 +532,9 @@
},
async addKeyword() {
if (this.newKeyword && this.newKeywordTrimmed.length > 0) {
let allTrimmedKeyword = this.newKeywordTrimmed.toLowerCase().split(',');
let allTrimmedKeyword = this.newKeywordTrimmed.split(',');
allTrimmedKeyword = allTrimmedKeyword.filter(e => String(e).trim());
if (!this.keywords.find(_keyword => allTrimmedKeyword.includes(_keyword.keyword.toLowerCase()))) {
if (!this.keywords.find(_keyword => allTrimmedKeyword.includes(_keyword.keyword))) {
for (var i = 0; i < allTrimmedKeyword.length; i++) {
let item = allTrimmedKeyword[i];
if (item.length > 0 && item.length <= 50) {
Expand Down
Loading