Skip to content

TD-4072: DIG201 Content has heading markup, but is not a heading issue fixed #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

TD-4072: DIG201 Content has heading markup, but is not a heading issue fixed #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/ContributeAuthorsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
v-bind:inputId="authorName"
v-bind:characterLimit="100"
v-bind:disabled="authorIsContributor"
:showTitle="false"
class="mt-25">
<template v-slot:description>
<label :for="'authorName'" class="mb-0">Author name</label>
Expand All @@ -39,6 +40,7 @@
<CharacterCount v-model="authorOrganisation"
v-bind:inputId="authorOrganisation"
v-bind:characterLimit="100"
:showTitle="false"
class="mt-15">
<template v-slot:description>
<label :for="'authorOrganisation'" class="mb-0">Organisation</label>
Expand All @@ -47,6 +49,7 @@
<CharacterCount v-model="authorRole"
v-bind:inputId="authorRole"
v-bind:characterLimit="100"
:showTitle="false"
class="mt-15">
<template v-slot:description>
<label :for="'authorRole'" class="mb-0">Role</label>
Expand Down
6 changes: 5 additions & 1 deletion LearningHub.Nhs.WebUI/Scripts/vuesrc/globalcomponents/CharacterCount.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
'character-count-component--error': (hasOtherError),
'character-count-component--large': (size === 'large'),
}">
<h2 class="nhsuk-heading-l">
<h2 class="nhsuk-heading-l" v-if="showTitle">
<slot name="title"></slot>
</h2>
<div class="mb-2">
Expand Down Expand Up @@ -98,6 +98,10 @@
disabled: Boolean,
focusOnLoad: Boolean,
size: String,
showTitle: {
default: true,
type: Boolean
}
},
data() {
return {
Expand Down
1 change: 1 addition & 0 deletions ...ningHub.Nhs.WebUI/Scripts/vuesrc/globalcomponents/CharacterCountWithSaveCancelButtons.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<CharacterCount v-model="inputValue"
v-bind:characterLimit="characterLimit"
v-bind:size="size"
:showTitle="false"
focusOnLoad></CharacterCount>
<div class="d-inline-flex">
<Button v-on:click="save"
Expand Down
4 changes: 3 additions & 1 deletion LearningHub.Nhs.WebUI/Views/Shared/Tenant/LearningHub/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,13 @@
<partial name="_CookieConsentPartial" />
</div>

<header class="nhsuk-header" role="banner" id="header">
<header class="nhsuk-header" role="banner">
<div id="content-header">
<partial name="~/Views/Shared/_NavPartial.cshtml" />
</div>
</header>
<div id="header">
</div>

<div class="nhsuk-width-container app-width-container beta-banner">
<span class="beta-banner__beta-box">BETA</span>
Expand Down
Loading