Skip to content

TD:4079: DIG301: Form fields are not associated with text labels #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024
Merged

TD:4079: DIG301: Form fields are not associated with text labels #731

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a41832
TD:4079: DIG301: Form fields are not associated with text labels
Swapnamol Nov 4, 2024
6f37266
accessbility fixes
Swapnamol Nov 4, 2024
1508bc7
Accessibility fixes
Swapnamol Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ....Nhs.WebUI/Scripts/vuesrc/contribute-resource/components/questions/SingleChoiceAnswer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
<hr class="cutoff-line">
</div>
<div>
<label class="nhsuk-u-visually-hidden" for="message"></label>
<input type="text" id="message" name="message" aria-describedby="messageError" class="form-control text-input" maxlength="120" v-model="message" />
<input type="text" aria-describedby="messageError" class="form-control text-input" maxlength="120" v-model="message" />
<div class="footer-text" id="messageError">
You have {{ charactersRemaining }} characters remaining.
</div>
Expand Down
4 changes: 2 additions & 2 deletions LearningHub.Nhs.WebUI/Views/Shared/Components/NavigationItems/MobileTopRightNav.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ else
<div class="nhsuk-header__mobile-break"></div>
@if (Model.ShowSearch)
{
<label class="nhsuk-header__search-toggle" id="toggle-search" aria-controls="search" aria-label="Open search">
<button class="nhsuk-header__search-toggle" id="toggle-search" aria-controls="search" aria-label="Open search">
<svg class="nhsuk-icon nhsuk-icon__search" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true" focusable="false" width="27" height="27">
<path d="M19.71 18.29l-4.11-4.1a7 7 0 1 0-1.41 1.41l4.1 4.11a1 1 0 0 0 1.42 0 1 1 0 0 0 0-1.42zM5 10a5 5 0 1 1 5 5 5 5 0 0 1-5-5z"></path>
</svg>
<span class="nhsuk-u-visually-hidden">Search</span>
</label>
</button>
}
}

Expand Down
6 changes: 3 additions & 3 deletions LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@

</div>
@if (User.Identity.IsAuthenticated) {
<input type="checkbox" id="header-dropdown-menu-control" aria-labelledby="Main navigation menu" role="button">
<input type="checkbox" id="header-dropdown-menu-control" aria-labelledby="label-navigation" role="button">
<nav class="nhsuk-header__navigation app-width-container" id="header-navigation" role="navigation" aria-label="Primary navigation" aria-labelledby="label-navigation">
<p class="nhsuk-header__navigation-title"><span id="label-navigation">Menu</span>
<label class="nhsuk-header__navigation-close" id="close-menu">
<button class="nhsuk-header__navigation-close" id="close-menu">
<svg class="nhsuk-icon nhsuk-icon__close" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true" focusable="false" width="27" height="27">
<path d="M13.41 12l5.3-5.29a1 1 0 1 0-1.42-1.42L12 10.59l-5.29-5.3a1 1 0 0 0-1.42 1.42l5.3 5.29-5.3 5.29a1 1 0 0 0 0 1.42 1 1 0 0 0 1.42 0l5.29-5.3 5.29 5.3a1 1 0 0 0 1.42 0 1 1 0 0 0 0-1.42z"></path>
</svg>
<span class="nhsuk-u-visually-hidden">Close menu</span>
</label>
</button>
</p>
<ul class="nhsuk-header__navigation-list @BasicUserPaddingClass()">
@await Component.InvokeAsync("NavigationItems")
Expand Down
Loading