Skip to content

TD-4079: Form elements should have an id attribute #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

TD-4079: Form elements should have an id attribute #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/ContributeAssessmentSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
<div class="d-flex">
<div class="selection pr-50">
<div class="mb-4">Allow the learner to work through the assessment pages in any order.</div>
<label class="my-0 label-text">
<input class="radio-button" type="radio" :value="false" v-model="assessmentDetails.answerInOrder"/>
<label class="my-0 label-text" for="yes">
<input class="radio-button" type="radio" :value="false" id="yes" v-model="assessmentDetails.answerInOrder"/>
Yes
</label>
<label class="my-0 pl-5 label-text">
<input class="radio-button" type="radio" :value="true" v-model="assessmentDetails.answerInOrder"/>
<label class="my-0 pl-5 label-text" for="no">
<input class="radio-button" type="radio" :value="true" id="no" v-model="assessmentDetails.answerInOrder"/>
No
</label>
</div>
Expand Down Expand Up @@ -74,7 +74,9 @@
<ckeditorwithhint v-on:blur="setEndGuidance"
v-on:inputValidity="setGuidanceValidity"
:maxLength="1000"
:initialValue="endGuidance" />
:initialValue="endGuidance"
:for="guidance"
:id="guidance"/>
</div>
<div class="tip">
<h3>Tip</h3>
Expand Down
6 changes: 3 additions & 3 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/ContributeAuthorsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@

<div v-if="resourceAuthors.length < maxAllowedAuthors" class="mb-40">
<LinkTextAndIcon v-if="!isAdding"
v-on:click="isAdding = true"
v-on:click="isAdding = true"Please choose...
class="contribute-authors-tab-add-button">
<i class="fa-solid fa-plus"></i> Add author
</LinkTextAndIcon>

<div v-if="isAdding">
<div class="mt-5" v-if="!isCurrentUserSavedAsAuthor">
<label class="checkContainer">
<label class="checkContainer" for="currentUserAuthor">
I am the author or co-author
<input type="checkbox" v-model="authorIsContributor" v-on:change="currentUserAuthorChange">
<input type="checkbox" id="currentUserAuthor" v-model="authorIsContributor" v-on:change="currentUserAuthorChange">
<span class="checkmark"></span>
</label>
</div>
Expand Down
6 changes: 3 additions & 3 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/ContributeLicenceTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
<a v-bind:href="moreInfoLink" class="mb-10 accessible-link" target="_blank">More information on licences</a>
</div>

<select class="form-control" aria-labelledby="licence-heading" v-model="resourceDetails.resourceLicenceId">
<option disabled v-bind:value="null">Please choose...</option>
<option v-for="licence in licences" :value="licence.id">
<select class="form-control" aria-labelledby="licence-heading" id="licence" v-model="resourceDetails.resourceLicenceId">
<option disabled v-bind:value="null" id="select">Please choose...</option>
<option v-for="licence in licences" :value="licence.id" :id="licence.id">
{{licence.title}}
</option>
</select>
Expand Down
2 changes: 1 addition & 1 deletion LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/components/CatalogueSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<CatalogueSelectorAccordion/>

<div class="form-group">
<select class="form-control" aria-labelledby="primary-catalogue-heading" v-model="selectedCatalogue" @change="catalogueChange">
<select class="form-control" aria-labelledby="primary-catalogue-heading" id="catalogue" v-model="selectedCatalogue" @change="catalogueChange">
<option disabled v-bind:value="{ nodeId: 0 }">Please choose...</option>
<option v-for="catalogue in userCatalogues" :value="catalogue">
{{getCatalogueName(catalogue)}}
Expand Down
4 changes: 2 additions & 2 deletions ...ngHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/components/SensitiveContentTickBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
</div>

<div class="mt-3">
<label class="checkContainer mb-0">
<label class="checkContainer mb-0" for="sensitivecontent">
Yes
<input type="checkbox" v-model="resourceDetails.sensitiveContent">
<input type="checkbox" id="sensitivecontent" v-model="resourceDetails.sensitiveContent">
<span class="checkmark"></span>
</label>
</div>
Expand Down
8 changes: 4 additions & 4 deletions ...ningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/components/questions/AllowReveal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
</div>
<form>

<label class="my-0">
<input class="radio-button" type="radio" :value="false" v-model="questionBlock.allowReveal"/>
<label class="my-0" for="no">
<input class="radio-button" type="radio" :value="false" v-model="questionBlock.allowReveal" id="no"/>
No
</label>
<br>
<label class="my-0">
<input class="radio-button" type="radio" :value="true" v-model="questionBlock.allowReveal"/>
<label class="my-0" for="yes">
<input class="radio-button" type="radio" :value="true" v-model="questionBlock.allowReveal" id="yes"/>
Yes
</label>
</form>
Expand Down
2 changes: 1 addition & 1 deletion ....Nhs.WebUI/Scripts/vuesrc/contribute-resource/components/questions/SingleChoiceAnswer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<hr class="cutoff-line">
</div>
<div>
<input type="text" aria-describedby="messageError" class="form-control text-input" maxlength="120" v-model="message" />
<input type="text" id="txtmessage" aria-describedby="messageError" class="form-control text-input" maxlength="120" v-model="message" />
<div class="footer-text" id="messageError">
You have {{ charactersRemaining }} characters remaining.
</div>
Expand Down
2 changes: 1 addition & 1 deletion LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/CatalogueSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

<div class="row">
<div class="form-group col-12">
<select class="form-control" aria-labelledby="type-label" v-model="selectedCatalogue" @change="catalogueChange">
<select class="form-control" aria-labelledby="type-label" id="catalogue" v-model="selectedCatalogue" @change="catalogueChange">
<option disabled v-bind:value="{ nodeId: 0 }">Please choose...</option>
<option v-for="catalogue in userCatalogues" :value="catalogue">
{{getCatalogueName(catalogue)}}
Expand Down
4 changes: 2 additions & 2 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/Content.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
</div>
<div class="row">
<div class="form-group col-12">
<select class="form-control" aria-labelledby="type-label" v-model="selectUploadResourceType" @change="onUploadResourceTypeChange">
<select class="form-control" aria-labelledby="type-label" id="uploadResourceTypes" v-model="selectUploadResourceType" @change="onUploadResourceTypeChange">
<option disabled v-bind:value="0">Please choose...</option>
<option v-for="option in uploadResourceTypes" :value="option.id">
{{ option.description }}
Expand Down Expand Up @@ -359,7 +359,7 @@
<div>
<div class="modal-section-header"><label for="notes">Notes</label></div>
<p class="mt-1">Provide information to help learners understand why this new version has been created.</p>
<textarea class="form-control"id="notes" v-bind:class="{ 'input-validation-error': $v.publishNotes.$invalid && $v.publishNotes.$dirty }" rows="4" maxlength="4000" v-model="publishNotes"></textarea>
<textarea class="form-control" id="notes" v-bind:class="{ 'input-validation-error': $v.publishNotes.$invalid && $v.publishNotes.$dirty }" rows="4" maxlength="4000" v-model="publishNotes"></textarea>
<div class="error-text pt-3" v-if="$v.publishNotes.$invalid && $v.publishNotes.$dirty">
<span class="text-danger">Enter notes.</span>
</div>
Expand Down
8 changes: 4 additions & 4 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/ContentCommon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@
<div class="bg-grey-white">
Do you want learners to be notified that this resource contains sensitive content, which they may find offensive or disturbing, before they access it?
<div class="mt-3">
<label class="checkContainer mb-0">
<label class="checkContainer mb-0" for="sensitivecontent">
Yes
<input type="checkbox" v-model="sensitiveContent" @click="setSensitiveContent($event.target.checked)">
<input type="checkbox" id="sensitivecontent" v-model="sensitiveContent" @click="setSensitiveContent($event.target.checked)">
<span class="checkmark"></span>
</label>
</div>
Expand Down Expand Up @@ -151,9 +151,9 @@
</div>
<div v-if="!userIsAuthor && authors.length < maxAllowedAuthors" class="col-12 mb-3">
<div>
<label class="checkContainer">
<label class="checkContainer" for="currentUserAuthor">
I am the author or co-author
<input type="checkbox" v-model="currentUserAuthor" @change="currentUserAuthorChange">
<input type="checkbox" id="currentUserAuthor" v-model="currentUserAuthor" @change="currentUserAuthorChange">
<span class="checkmark"></span>
</label>
</div>
Expand Down
2 changes: 1 addition & 1 deletion LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute/ContentVideo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
for example, how it was developed or what is required for it to be used.
</div>
<div class="col-12 mt-3">
<textarea class="form-control" aria-labelledby="additionalinfo-label" rows="4" maxlength="250" v-model="additionalInformation" @change="setAdditionalInformation($event.target.value)"></textarea>
<textarea class="form-control" id="additionalinfo" aria-labelledby="additionalinfo-label" rows="4" maxlength="250" v-model="additionalInformation" @change="setAdditionalInformation($event.target.value)"></textarea>
</div>
<div class="col-12 footer-text">
You can enter a maximum of 250 characters
Expand Down
2 changes: 1 addition & 1 deletion LearningHub.Nhs.WebUI/Scripts/vuesrc/learningsessions/ScormViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</div>
<div class="text-popup" v-show="textLogVisible">
<button @click="textLogVisible=false">close</button>
<textarea v-model="textLog"></textarea>
<textarea v-model="textLog" id="log"></textarea>
</div>
</div>
</template>
Expand Down
Loading