Skip to content

TD-4182-Error suggestion is not clear #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

TD-4182-Error suggestion is not clear #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion LearningHub.Nhs.WebUI/Controllers/AccountController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,7 @@ public async Task<IActionResult> CreateAccountProfessionalRegNumber(AccountCreat
/// </summary>
/// <returns>The <see cref="IActionResult"/>.</returns>
/// <param name="accountCreationViewModel">accountCreationViewModel.</param>
[HttpPost]
[Route("Registration/CreateAccountGradeSelection")]
[ResponseCache(CacheProfileName = "Never")]
[TypeFilter(typeof(RedirectMissingMultiPageFormData), Arguments = new object[] { nameof(MultiPageFormDataFeature.AddRegistrationPrompt) })]
Expand All @@ -672,7 +673,7 @@ public async Task<IActionResult> CreateAccountGradeSelection(AccountCreationView

if (string.IsNullOrWhiteSpace(accountCreationViewModel.RegistrationNumber) && accountCreation.MedicalCouncilId.HasValue && (int)accountCreation.MedicalCouncilId > 0)
{
this.ModelState.AddModelError("RegistrationNumber", $"You must provide a {accountCreation.MedicalCouncilCode} Number");
this.ModelState.AddModelError("RegistrationNumber", $"{accountCreation.MedicalCouncilName} Number is required");
this.ViewBag.Job = await this.jobRoleService.GetByIdAsync(roleId);
accountCreationViewModel.CurrentRole = roleId.ToString();
return this.View("CreateAccountProfessionalRegNumber", accountCreationViewModel);
Expand Down
6 changes: 2 additions & 4 deletions LearningHub.Nhs.WebUI/Views/Account/CreateAccountProfessionalRegNumber.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<h1 class="nhsuk-heading-xl">Enter your @jobDetails.MedicalCouncilCode number</h1>


<form asp-controller="Account" asp-action="CreateAccountGradeSelection" method="get">
<form asp-controller="Account" asp-action="CreateAccountGradeSelection" method="post">
<input type="hidden" name="formSubmission" value="true">
@if (errorHasOccurred)
{
Expand Down Expand Up @@ -52,9 +52,7 @@
hint-text=""
autocomplete=""
css-class="nhsuk-u-width-one-half"
required="true"
required-client-side-error-message="@jobDetails.MedicalCouncilName Number is required" />

required="false"/>

<div class="nhsuk-form-group">
<button type="submit" class="nhsuk-button">Continue</button>
Expand Down
Loading