Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions LearningHub.Nhs.WebUI/Controllers/AccountController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ public async Task<IActionResult> CreateAccountRegionSelection(AccountCreationVie

if (accountCreation.CountryId == "1")
{
await this.multiPageFormService.SetMultiPageFormData(accountCreation, MultiPageFormDataFeature.AddRegistrationPrompt, this.TempData);
var regionData = await this.regionService.GetAllPagedAsync(accountCreationViewModel.CurrentPageIndex, UserRegistrationContentPageSize);
return this.View(new AccountCreationListViewModel { Region = regionData.Item2, AccountCreationPaging = new AccountCreationPagingModel { TotalItems = regionData.Item1, PageSize = UserRegistrationContentPageSize, HasItems = regionData.Item1 > 0, CurrentPage = accountCreationViewModel.CurrentPageIndex }, RegionId = accountCreation.RegionId, ReturnToConfirmation = accountCreationViewModel.ReturnToConfirmation });
}
Expand Down Expand Up @@ -537,7 +538,7 @@ public async Task<IActionResult> CreateAccountSubmitRegionSelection(AccountCreat

if (string.IsNullOrWhiteSpace(accountCreationViewModel.RegionId))
{
if (accountCreation.CountryId == "1")
if (accountCreation.CountryId == "1" || accountCreation.CountryId == null)
{
this.ModelState.AddModelError("RegionId", CommonValidationErrorMessages.RegionRequired);
var region = await this.regionService.GetAllPagedAsync(1, UserRegistrationContentPageSize);
Expand Down Expand Up @@ -748,7 +749,7 @@ public async Task<IActionResult> CreateAccountPrimarySpecialty(AccountCreationVi
if (string.IsNullOrWhiteSpace(accountCreationViewModel.GradeId) || !gradeCheck)
{
int gradePageSize = UserRegistrationContentPageSize + 5;
this.ModelState.AddModelError(string.Empty, CommonValidationErrorMessages.GradeRequired);
this.ModelState.AddModelError("GradeId", CommonValidationErrorMessages.GradeRequired);
var gradeLevel = await this.gradeService.GetPagedGradesForJobRoleAsync(int.Parse(accountCreation.CurrentRole), 1, gradePageSize);
return this.View("CreateAccountGradeSelection", new AccountCreationListViewModel { GradeList = gradeLevel.Item2, AccountCreationPaging = new AccountCreationPagingModel { TotalItems = gradeLevel.Item1, PageSize = gradePageSize, HasItems = gradeLevel.Item1 > 0, CurrentPage = 1 }, ReturnToConfirmation = accountCreationViewModel.ReturnToConfirmation });
}
Expand Down
2 changes: 1 addition & 1 deletion LearningHub.Nhs.WebUI/LearningHub.Nhs.WebUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.4.1" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="6.0.10" />
<PackageReference Include="MK.IO" Version="1.5.0" />
<PackageReference Include="NHSUKViewComponents.Web" Version="1.0.25" />
<PackageReference Include="NHSUKViewComponents.Web" Version="1.0.26" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

@{
ViewData["Title"] = "Select Country";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
bool returnToConfirmation = false;
if (!string.IsNullOrWhiteSpace(Context.Request.Query["returnToConfirmation"]))
Expand All @@ -25,7 +26,7 @@

@if (errorHasOccurred)
{
<vc:error-summary order-of-property-names="@(new[] { nameof(Model.FilterText) })" />
<vc:error-summary order-of-property-names="@(new[] { nameof(Model.FilterText), nameof(Model.CountryId) })" />
}
<h1 class="nhsuk-heading-xl">Search results for @Model.FilterText</h1>
<form asp-controller="Account" asp-action="CreateAccountCountrySelection" method="get">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

@{
ViewData["Title"] = "Current Role";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
bool returnToConfirmation = false;
if (!string.IsNullOrWhiteSpace(Context.Request.Query["returnToConfirmation"]))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

@{
ViewData["Title"] = "Email Verification";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
bool returnToConfirmation = false;
if (!string.IsNullOrWhiteSpace(Context.Request.Query["returnToConfirmation"]))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

@{
ViewData["Title"] = "Select Grade";
ViewData["DisableValidation"] = true;
string currentRole = !string.IsNullOrWhiteSpace(Context.Request.Query["CurrentRole"]) ? Context.Request.Query["CurrentRole"] : Model.CurrentRole;
var routeData = new Dictionary<string, string> { { "CurrentRole", currentRole }, { "ReturnToConfirmation", Context.Request.Query["returnToConfirmation"] } };
var errorHasOccurred = !ViewData.ModelState.IsValid;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

@{
ViewData["Title"] = "Personal details";
ViewData["DisableValidation"] = true;
string email = ViewBag.ValidatedEmail;
var errorHasOccurred = !ViewData.ModelState.IsValid;
AccountCreationTypeEnum accountCreationType = ViewBag.AccountCreationType;
Expand Down Expand Up @@ -49,7 +50,7 @@
<input type="hidden" name="formSubmission" value="true">
@if (errorHasOccurred)
{
<vc:error-summary order-of-property-names="@(new[] { nameof(Model) })" />
<vc:error-summary order-of-property-names="@(new[] { nameof(Model.FirstName),nameof(Model.LastName) })" />
}

<vc:text-input asp-for="FirstName"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

@{
ViewData["Title"] = "Primary Specialty";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
string grade = !string.IsNullOrWhiteSpace(Context.Request.Query["gradeId"]) ? Context.Request.Query["gradeId"] : Model.GradeId;
string regNo = !string.IsNullOrWhiteSpace(Context.Request.Query["registrationNumber"]) ? Context.Request.Query["registrationNumber"] : Model.RegistrationNumber;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

@{
ViewData["Title"] = "Region";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
var routeData = new Dictionary<string, string> { { "ReturnToConfirmation", Context.Request.Query["returnToConfirmation"] } };
}
Expand All @@ -16,7 +17,7 @@
<vc:back-link asp-controller="Account" asp-action="CreateAccountCountrySelection" asp-all-route-data="@routeData" link-text="Back to: Search for your country" />
@if (errorHasOccurred)
{
<vc:error-summary order-of-property-names="@(new[] { nameof(Model) })" />
<vc:error-summary order-of-property-names="@(new[] { nameof(Model.RegionId) })" />
}
<form asp-controller="Account" asp-action="CreateAccountSubmitRegionSelection" method="post">
<input type="hidden" name="formSubmission" value="true">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

@{
ViewData["Title"] = "Work Place";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
TextInfo textInfo = CultureInfo.CurrentCulture.TextInfo;
bool returnToConfirmation = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

@{
ViewData["Title"] = "Start Date";
ViewData["DisableValidation"] = true;
var errorHasOccurred = !ViewData.ModelState.IsValid;
var exampleDate = DateTime.Today;
var hintTextLines = new List<string> { $"Enter the date you started your current role, for example, 24 08 2021" };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,11 @@
<script type="text/javascript" src="~/lib/bootstrap/dist/js/bootstrap.bundle.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/js/jquery.matchHeight.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/js/site.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/lib/jquery-validation/dist/jquery.validate.min.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js" asp-append-version="true"></script>
@if (!ViewData["DisableValidation"]?.Equals(true) ?? true)
{
<script type="text/javascript" src="~/lib/jquery-validation/dist/jquery.validate.min.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js" asp-append-version="true"></script>
}
</environment>
<environment exclude="Development">
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"
Expand All @@ -127,20 +130,23 @@
crossorigin="anonymous"
integrity="sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=">
</script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery-validate/1.19.5/jquery.validate.min.js"
asp-fallback-src="~/lib/jquery-validation/dist/jquery.validate.min.js"
asp-fallback-test="window.jQuery && window.jQuery.validator"
asp-suppress-fallback-integrity="true"
crossorigin="anonymous"
integrity="sha512-rstIgDs0xPgmG6RX1Aba4KV5cWJbAMcvRCVmglpam9SoHZiUCyQVDdH2LPlxoHtrv17XWblE/V/PP+Tr04hbtA==">
</script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery-validation-unobtrusive/4.0.0/jquery.validate.unobtrusive.min.js"
asp-fallback-src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js"
@if (!ViewData["DisableValidation"]?.Equals(true) ?? true)
{
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery-validate/1.19.5/jquery.validate.min.js"
asp-fallback-src="~/lib/jquery-validation/dist/jquery.validate.min.js"
asp-fallback-test="window.jQuery && window.jQuery.validator"
asp-suppress-fallback-integrity="true"
crossorigin="anonymous"
integrity="sha512-rstIgDs0xPgmG6RX1Aba4KV5cWJbAMcvRCVmglpam9SoHZiUCyQVDdH2LPlxoHtrv17XWblE/V/PP+Tr04hbtA==">
</script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery-validation-unobtrusive/4.0.0/jquery.validate.unobtrusive.min.js"
asp-fallback-src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js"
asp-fallback-test="window.jQuery && window.jQuery.validator && window.jQuery.validator.unobtrusive"
asp-suppress-fallback-integrity="true"
crossorigin="anonymous"
integrity="sha512-xq+Vm8jC94ynOikewaQXMEkJIOBp7iArs3IhFWSWdRT3Pq8wFz46p+ZDFAR7kHnSFf+zUv52B3prRYnbDRdgog==">
</script>
}
<script src="~/lib/bootstrap/dist/js/bootstrap.bundle.min.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/js/jquery.matchHeight.min.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/js/site.min.js" asp-append-version="true"></script>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<environment include="Development">
<script src="~/lib/jquery-validation/dist/jquery.validate.js"></script>
@if (!ViewData["DisableValidation"]?.Equals(true) ?? true)
{
<environment include="Development">
<script src="~/lib/jquery-validation/dist/jquery.validate.js"></script>
<script src="~/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js"></script>
</environment>
<environment exclude="Development">
Expand All @@ -16,6 +18,7 @@
integrity="sha256-9GycpJnliUjJDVDqP0UEu/bsm9U+3dnQUH8+3W10vkY=">
</script>
</environment>
}
<script type="text/javascript">
// Add/remove class 'input-validation-error' to the div containing the control with error

Expand Down
Loading