Skip to content

download file code refactor to stream large file rather than downloading files internally #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

download file code refactor to stream large file rather than downloading files internally #798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions LearningHub.Nhs.WebUI/Services/FileService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,26 @@ public async Task<FileDownloadResponse> DownloadFileAsync(string filePath, strin

try
{
// Directly download the entire file as a stream
var response = await file.DownloadAsync();
return new FileDownloadResponse
if (fileSize <= 900 * 1024 * 1024)
{
Content = response.Value.Content,
ContentType = properties.Value.ContentType,
ContentLength = fileSize,
};
// Directly download the entire file as a stream
var response = await file.DownloadAsync();
return new FileDownloadResponse
{
Content = response.Value.Content,
ContentType = properties.Value.ContentType,
ContentLength = fileSize,
};
}
else
{
return new FileDownloadResponse
{
Content = await file.OpenReadAsync(),
ContentType = properties.Value.ContentType,
ContentLength = fileSize,
};
}
}
catch (Exception ex)
{
Expand Down
Loading