Skip to content

Conversation

OluwatobiAwe
Copy link
Contributor

@OluwatobiAwe OluwatobiAwe commented Jan 8, 2025

JIRA link

TD-4180

Description

Grouped form controls within the view component has now been updated to focus on the first item in a radio list when an error occurred. A viewdata was introduced to capture form fields that are grouped. This allows the view component to assign the correct incremental ID which aligns with how IDs are generated in a radiogroup.

Screenshots

image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@OluwatobiAwe OluwatobiAwe merged commit e68042d into RC Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants