Skip to content

Conversation

AnjuJose011
Copy link
Contributor

JIRA link

TD-###

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

akdalin-hee and others added 30 commits May 31, 2024 11:38
…cedLearning/LearningHub.Nhs.WebUI into Develop/Feature/TD-3678-Implement-OpenAPI-endpoints-to-retrieve-My-Accessed-Learning-resources
AnjuJose011 and others added 29 commits December 20, 2024 12:28
…edHeaderContents

TD-4193-needs to change the second word starting letter to upper case
…/TD-5176

TD-5176 Large file download fix.
…ldNumber

Merge Build Number Changes to RC
…/TD-5130-Clearing-old-country-selection-on-new-search

TD-5130: Clearing country selection on new search
…/TD-5130-Fixed-unknown-error

TD-5130: Fixed unknown error
…/TD-4196-Focus-issue-fixed-on-mycontibutions-page

TD-4196: Fixed focus issue on my contributions page
…/TD-5176

download file code refactor to stream large file rather than downloading files internally
…/TD-4180

programmatically associating error summary with  form field
…/TD-4180

Added a missing parameter - gardeId
TD-5238-elearning resource page doesn't refresh properly upon completing elearning
@AnjuJose011 AnjuJose011 merged commit d1eb8d0 into master Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants