Skip to content

Conversation

@OluwatobiAwe
Copy link
Contributor

@OluwatobiAwe OluwatobiAwe commented Jan 16, 2025

JIRA link

TD-5118

Description

moved p1 endpoints to OpenAPI
added some variable to appsettings file

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, @OluwatobiAwe. We may want to review and refine some of the documentation in the future. Is there a Swagger page where I can see these endpoints documented?

@OluwatobiAwe
Copy link
Contributor Author

OluwatobiAwe commented Feb 5, 2025

Apologies for missing your comment earlier, that was an oversight on my part. I've now created a new PR TD-5118 that includes the P 1- 3 endpoints. For the Swagger view, This can be seen by launching the OpenAPI webapi project.

@AnjuJose011 AnjuJose011 merged commit 34bbb27 into RC Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants