Skip to content

Conversation

@Phil-NHS
Copy link
Collaborator

PR Template

TODO:

Test it here too
https://technologyenhancedlearning.github.io/GitPageBlazorWASM-TestGHPage/
check version matches branch name and pullrequest release

  • maybe a rule that any introduced css for example if bringing in an enum. needs to be refactored to nhse-tel? so tel-nhse is source of truth on all things css

TODO: About

  • SO FAR no js controllers are not going to be covered in testing in the package it will be done by how used in LH
    But in future we could simulate them with just an api with stock response or find a programatic way, or build a hosted environment.
    The gh-page are pure wasm so not supported for nojs

  • brave check no js (Locally not on wasm static test page)

TODO: This is just replicating LH for now ... ideas

  • Link to replicated component
  • Link design confluence if coming from design
  • Tick box for JS
  • If testers find an issue create an automated test of what they did, even potentially with playright record test functionality
  • something about is there a linked lh branch using the change

JIRA link

TD-####

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.7.0-feat-button-for-cicd-testing.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Phil-NHS and others added 2 commits June 11, 2025 15:56
# [1.8.0-feat-button-for-cicd-testing.1](v1.7.0...v1.8.0-feat-button-for-cicd-testing.1) (2025-06-11)

### Features

* **button:** versioning from assembly not file parsing ([4b8c773](4b8c773))
@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.8.0-feat-button-for-cicd-testing.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.8.0-feat-button-for-cicd-testing.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.8.0-feat-button-for-cicd-testing.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Phil-NHS Phil-NHS merged commit f3be1f1 into master Jun 16, 2025
1 check passed
@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants