Skip to content

TD-5931: Warning message is showing due to optional parameter #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Ci
merged 1 commit into from
Aug 19, 2025
Merged

TD-5931: Warning message is showing due to optional parameter #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions local/mylearningservice/externallib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ public static function get_recent_courses_parameters() {
// Allow omission by setting VALUE_DEFAULT and defaulting to 0 (meaning no limit)
'months' => new external_value(PARAM_INT, 'Number of past months to include', VALUE_DEFAULT, 0),
// Optional status filter
'statusfilter' => new external_value(PARAM_ALPHA, 'Course status filter: completed, inprogress, or empty for all', VALUE_DEFAULT, ''),
'statusfilter' => new external_value(PARAM_TEXT, 'Course status filter: completed, inprogress, or empty for all', VALUE_DEFAULT, ''),
// Optional search term
'search' => new external_value(PARAM_RAW, 'Search keyword for course fullname/shortname', VALUE_DEFAULT, '')
'search' => new external_value(PARAM_TEXT, 'Search keyword for course fullname/shortname', VALUE_DEFAULT, '')
)
);
}
Expand Down Expand Up @@ -295,7 +295,7 @@ public static function get_user_certificates_parameters() {
return new external_function_parameters(
[
'userid' => new external_value(PARAM_INT, 'User ID'),
'searchterm' => new external_value(PARAM_RAW, 'Search keyword for filtering certificates', VALUE_OPTIONAL)
'searchterm' => new external_value(PARAM_TEXT, 'Search keyword for filtering certificates', VALUE_DEFAULT, '')
]
);
}
Expand Down
2 changes: 1 addition & 1 deletion local/mylearningservice/version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'local_mylearningservice';
$plugin->version = 2025073103;
$plugin->version = 2025073104;
$plugin->requires = 2024100290;
$plugin->maturity = MATURITY_STABLE;
$plugin->release = '1.0';