Skip to content

TD-6192: EndDate and LastAccessDate columns showing null scenario has been handled #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Ci
merged 1 commit into from
Sep 15, 2025
Merged

TD-6192: EndDate and LastAccessDate columns showing null scenario has been handled #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions local/mylearningservice/externallib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,15 @@ function($favourite) {
}

$enrolrecords = $DB->get_records_sql("
SELECT ue.timestart,ue.timeend
SELECT ue.timestart, cc.timecompleted ,ula.timeaccess
FROM {user_enrolments} ue
JOIN {enrol} e ON ue.enrolid = e.id
LEFT JOIN {course_completions} cc
ON cc.userid = ue.userid
AND cc.course = e.courseid
LEFT JOIN {user_lastaccess} ula
ON ula.userid = ue.userid
AND ula.courseid = e.courseid
WHERE ue.userid = :userid AND e.courseid = :courseid
ORDER BY ue.timestart DESC
", [
Expand All @@ -77,7 +83,8 @@ function($favourite) {
if (!empty($enrolrecords)) {
$firstrecord = reset($enrolrecords); // Gets first item
$enroltime = (int)$firstrecord->timestart;
$enrolendtime=(int)$firstrecord->timeend;
$enrolendtime=(int)$firstrecord->timecompleted;
$lastaccessdate =(int)$firstrecord->timeaccess;
}
if(!empty($months))
{
Expand Down Expand Up @@ -220,7 +227,8 @@ function($favourite) {
'timemodified' => $course->timemodified,
'certificateenabled'=>$hascertificate,
'totalactivities' => $totalactivities,
'completedactivities'=>$completedactivities
'completedactivities'=>$completedactivities,
'lastaccessdate'=>$lastaccessdate

];
if ($returnusercount) {
Expand Down Expand Up @@ -286,6 +294,7 @@ public static function get_recent_courses_returns() {
'certificateenabled' => new external_value(PARAM_BOOL, 'Whether the course has certificate.', VALUE_OPTIONAL),
'totalactivities' => new external_value(PARAM_INT, 'total activities', VALUE_OPTIONAL),
'completedactivities' => new external_value(PARAM_INT, 'completed activities count', VALUE_OPTIONAL),
'lastaccessdate' => new external_value(PARAM_INT, 'Timestamp when the user access the course last', VALUE_OPTIONAL),
)
)
);
Expand Down
2 changes: 1 addition & 1 deletion local/mylearningservice/version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'local_mylearningservice';
$plugin->version = 2025073105;
$plugin->version = 2025073106;
$plugin->requires = 2024100290;
$plugin->maturity = MATURITY_STABLE;
$plugin->release = '1.0';