Skip to content

Conversation

@binon
Copy link
Contributor

@binon binon commented Apr 3, 2025

Implemented OIDC and fixed the redirect issue. To get this working we need to update moodle configuration on UI and Auth appsettings

@gitguardian
Copy link

gitguardian bot commented Apr 3, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15558685 Triggered Generic Password 6b23287 auth/oidc/classes/form/application.php View secret
5785368 Triggered Generic Password 6b23287 auth/oidc/tests/privacy_provider_test.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@binon binon requested review from ColinBeebyHEE and Copilot April 3, 2025 11:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements OpenID Connect support and addresses a redirect issue by updating configuration in both the Moodle UI and Auth appsettings. Key changes include the addition of security documentation, updated README for OIDC installation instructions, and CI/CD configuration updates for testing and deployment.

Reviewed Changes

Copilot reviewed 62 out of 77 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
auth/oidc/SECURITY.md Added a security documentation file following Microsoft guidelines.
auth/oidc/README.md Provided documentation for installing and using the OIDC plugin.
auth/oidc/.gitlab-ci.yml Introduced CI configuration for running Moodle plugin tests.
auth/oidc/.github/workflows/ci.yml Added a GitHub Actions workflow for continuous integration of the plugin.
.github/workflows/learninghub-moodle_Deploy_test.yml Updated deployment configuration targeting the test environment.
Files not reviewed (15)
  • Terraform/test/main.tf: Language not supported
  • auth/oidc/.github/PULL_REQUEST_TEMPLATE.txt: Language not supported
  • auth/oidc/auth.php: Language not supported
  • auth/oidc/binding_username_claim.php: Language not supported
  • auth/oidc/change_binding_username_claim_tool.php: Language not supported
  • auth/oidc/classes/adminsetting/auth_oidc_admin_setting_iconselect.php: Language not supported
  • auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php: Language not supported
  • auth/oidc/classes/adminsetting/auth_oidc_admin_setting_loginflow.php: Language not supported
  • auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php: Language not supported
  • auth/oidc/classes/adminsetting/iconselect.css: Language not supported
  • auth/oidc/classes/event/action_failed.php: Language not supported
  • auth/oidc/classes/event/user_authed.php: Language not supported
  • auth/oidc/classes/event/user_connected.php: Language not supported
  • auth/oidc/classes/event/user_created.php: Language not supported
  • auth/oidc/classes/event/user_disconnected.php: Language not supported


1. Unpack the plugin into /auth/oidc within your Moodle install.
2. From the Moodle Administration block, expand Site Administration and click "Notifications".
3. Follow the on-screen instuctions to install the plugin.
Copy link

Copilot AI Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo detected: 'instuctions' should be corrected to 'instructions'.

Suggested change
3. Follow the on-screen instuctions to install the plugin.
3. Follow the on-screen instructions to install the plugin.

Copilot uses AI. Check for mistakes.
@ColinBeebyHEE ColinBeebyHEE merged commit 1fb4843 into CI Apr 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants