Refactor manager: harden epoch vote collector flow#561
Open
TanguyDeTaxis wants to merge 2 commits intoTelcoin-Association:mainfrom
Open
Refactor manager: harden epoch vote collector flow#561TanguyDeTaxis wants to merge 2 commits intoTelcoin-Association:mainfrom
TanguyDeTaxis wants to merge 2 commits intoTelcoin-Association:mainfrom
Conversation
…lector module directly from manager, extract epoch vote collector and fix alt-vote tracking (Telcoin-Association#547) - drain epoch votes while waiting for epoch records - switch collector timeout loop to interval-based collection - strengthen peer fallback retries for epoch cert recovery - add coverage for epoch vote handler validation and validator-ejection cert checks
TanguyDeTaxis
had a problem deploying
to
merge-into-main
GitHub Actions
Failure
TanguyDeTaxis
had a problem deploying
to
merge-into-main
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
epoch_vote_collectorlifecycle and split flow into explicit helpersvote_rxwhile waiting for epoch records to avoid channel buildupIssue Coverage
manager.rs: Extract Epoch Vote Collector and Harden Logic #547Testing
RUSTC_WRAPPER= cargo test -p tn-node epoch_vote_collector -- --nocaptureRUSTC_WRAPPER= cargo test -p tn-primary test_epoch_vote_gossip_rejects_unknown_authority_when_epoch_record_known -- --nocaptureRUSTC_WRAPPER= cargo test -p tn-types test_epoch_record_cert_with_signer_ejected_from_next_committee -- --nocapture